magento/adobe-stock-integration#1727: Introduce internal class wrapping SplFileInfo - fix static and mftf fails, added integration tets

Author: joweecaquicla

app/code/Magento/MediaGallerySynchronization/Model/Filesystem/FileInfo.php

@@ -8,7 +8,9 @@
 namespace Magento\MediaGallerySynchronization\Model\Filesystem;
 
 /**
- * Class FileInfo
+ * Internal class wrapping \SplFileInfo
+ *
+ * @SuppressWarnings(PHPMD.TooManyFields)
  */
 class FileInfo extends \SplFileInfo
 {
@@ -37,11 +39,6 @@ class FileInfo extends \SplFileInfo
      */
     private $pathname;
 
-    /**
-     * @var int
-     */
-    private $perms;
-
     /**
      * @var int
      */
@@ -87,16 +84,6 @@ class FileInfo extends \SplFileInfo
      */
     private $realPath;
 
-    /**
-     * @var \SplFileInfo
-     */
-    private $fileInfo;
-
-    /**
-     * @var \SplFileInfo
-     */
-    private $pathInfo;
-
     /**
      * FileInfo constructor.
      * @param string $file_name
@@ -105,7 +92,6 @@ class FileInfo extends \SplFileInfo
      * @param string $extension
      * @param string $basename
      * @param string $pathname
-     * @param int $perms
      * @param int $inode
      * @param int $size
      * @param int $owner
@@ -115,8 +101,7 @@ class FileInfo extends \SplFileInfo
      * @param int $cTime
      * @param string $type
      * @param false|string $realPath
-     * @param \SplFileInfo $fileInfo
-     * @param \SplFileInfo $pathInfo
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         string $file_name,
@@ -125,7 +110,6 @@ public function __construct(
         string $extension,
         string $basename,
         string $pathname,
-        int $perms,
         int $inode,
         int $size,
         int $owner,
@@ -134,17 +118,14 @@ public function __construct(
         int $mTime,
         int $cTime,
         string $type,
-        $realPath,
-        \SplFileInfo $fileInfo,
-        \SplFileInfo $pathInfo
+        $realPath
     ) {
         parent::__construct($file_name);
         $this->path = $path;
         $this->filename = $filename;
         $this->extension = $extension;
         $this->basename = $basename;
         $this->pathname = $pathname;
-        $this->perms = $perms;
         $this->inode = $inode;
         $this->size = $size;
         $this->owner = $owner;
@@ -154,8 +135,6 @@ public function __construct(
         $this->cTime = $cTime;
         $this->type = $type;
         $this->realPath = $realPath;
-        $this->fileInfo = $fileInfo;
-        $this->pathInfo = $pathInfo;
     }
 
     /**
@@ -198,14 +177,6 @@ public function getPathname(): string
         return $this->pathname;
     }
 
-    /**
-     * @inheritDoc
-     */
-    public function getPerms(): int
-    {
-        return $this->perms;
-    }
-
     /**
      * @inheritDoc
      */
@@ -277,20 +248,4 @@ public function getRealPath()
     {
         return $this->realPath;
     }
-
-    /**
-     * @inheritDoc
-     */
-    public function getFileInfo($class_name = null): \SplFileInfo
-    {
-        return $this->fileInfo;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getPathInfo($class_name = null): \SplFileInfo
-    {
-        return $this->pathInfo;
-    }
 }

app/code/Magento/MediaGallerySynchronization/Model/Filesystem/GetFileInfo.php

@@ -44,7 +44,7 @@ public function execute(string $path): FileInfo
             'path' => $splFileInfo->getPath(),
             'filename' => $splFileInfo->getFilename(),
             'extension' => $splFileInfo->getExtension(),
-            'basename' => $splFileInfo->getBasename(),
+            'basename' => $splFileInfo->getBasename('.' . $splFileInfo->getExtension()),
             'pathname' => $splFileInfo->getPathname(),
             'perms' => $splFileInfo->getPerms(),
             'inode' => $splFileInfo->getInode(),
@@ -55,9 +55,7 @@ public function execute(string $path): FileInfo
             'mTime' => $splFileInfo->getMTime(),
             'cTime' => $splFileInfo->getCTime(),
             'type' => $splFileInfo->getType(),
-            'realPath' => $splFileInfo->getRealPath(),
-            'fileInfo' => $splFileInfo->getFileInfo(),
-            'pathInfo' => $splFileInfo->getPathInfo()
+            'realPath' => $splFileInfo->getRealPath()
         ]);
     }
 }

app/code/Magento/MediaGallerySynchronization/Test/Integration/Model/Filesystem/GetFileInfoTest.php

@@ -0,0 +1,94 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\MediaGallerySynchronization\Test\Integration\Model\Filesystem;
+
+use Magento\MediaGallerySynchronization\Model\Filesystem\GetFileInfo;
+use Magento\TestFramework\Helper\Bootstrap;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Integration test for GetFileInfo
+ */
+class GetFileInfoTest extends TestCase
+{
+    /**
+     * @var GetFileInfo
+     */
+    private $getFileInfo;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp(): void
+    {
+        $this->getFileInfo = Bootstrap::getObjectManager()->get(GetFileInfo::class);
+    }
+
+    /**
+     * @dataProvider filesProvider
+     * @param string $file
+     */
+    public function testExecute(
+        string $file
+    ): void {
+
+        $path = $this->getImageFilePath($file);
+
+        $fileInfo = $this->getFileInfo->execute($path);
+        $this->assertNotEmpty($fileInfo->getPath());
+        $this->assertNotEmpty($fileInfo->getFilename());
+        $this->assertNotEmpty($fileInfo->getExtension());
+        $this->assertNotEmpty($fileInfo->getBasename());
+        $this->assertNotEmpty($fileInfo->getPathname());
+        $this->assertNotEmpty($fileInfo->getPerms());
+        $this->assertNotEmpty($fileInfo->getInode());
+        $this->assertNotEmpty($fileInfo->getSize());
+        $this->assertNotEmpty($fileInfo->getOwner());
+        $this->assertNotEmpty($fileInfo->getGroup());
+        $this->assertNotEmpty($fileInfo->getATime());
+        $this->assertNotEmpty($fileInfo->getMTime());
+        $this->assertNotEmpty($fileInfo->getCTime());
+        $this->assertNotEmpty($fileInfo->getType());
+        $this->assertNotEmpty($fileInfo->getRealPath());
+
+    }
+
+    /**
+     * Data provider for testExecute
+     *
+     * @return array[]
+     */
+    public function filesProvider(): array
+    {
+        return [
+            [
+                'magento.jpg',
+                'magento_2.jpg'
+            ]
+        ];
+    }
+
+    /**
+     * Return image file path
+     *
+     * @param string $filename
+     * @return string
+     */
+    private function getImageFilePath(string $filename): string
+    {
+        return dirname(__DIR__, 2)
+            . DIRECTORY_SEPARATOR
+            . implode(
+                DIRECTORY_SEPARATOR,
+                [
+                    '_files',
+                    $filename
+                ]
+            );
+    }
+}