[TASK] Always setSaveRewritesHistory to 1 for API calls so there will be created a SEO rewrite for the old url

Author: lewisvoncken

app/code/Magento/CatalogUrlRewrite/Observer/ProductSaveRewritesHistorySetterObserver.php

@@ -0,0 +1,49 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\CatalogUrlRewrite\Observer;
+
+use Magento\Catalog\Model\Product;
+use Magento\Framework\Event\ObserverInterface;
+use Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator;
+
+/**
+ * Class ProductSaveRewritesHistorySetterObserver
+ *
+ * @package Magento\CatalogUrlRewrite\Observer
+ */
+class ProductSaveRewritesHistorySetterObserver implements ObserverInterface
+{
+    /**
+     * @var \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator
+     */
+    private $productUrlPathGenerator;
+
+    /**
+     * @param ProductUrlPathGenerator $productUrlPathGenerator
+     */
+    public function __construct(ProductUrlPathGenerator $productUrlPathGenerator)
+    {
+        $this->productUrlPathGenerator = $productUrlPathGenerator;
+    }
+
+    /**
+     * Always set save_rewrites_history to 1 for API calls so there will always be created a SEO rewrite for the old url
+     *
+     * @param  \Magento\Framework\Event\Observer $observer
+     * @return void
+     */
+    public function execute(\Magento\Framework\Event\Observer $observer)
+    {
+        /**
+         * @var Product $product
+         */
+        $product = $observer->getEvent()->getProduct();
+        $urlKey = $this->productUrlPathGenerator->getUrlKey($product);
+        if (null !== $urlKey) {
+            $product->setSaveRewritesHistory(1);
+        }
+    }
+}

app/code/Magento/CatalogUrlRewrite/Observer/ProductUrlKeyAutogeneratorObserver.php

@@ -7,15 +7,19 @@
 
 use Magento\Catalog\Model\Product;
 use Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator;
-use Magento\Framework\Event\Observer;
 use Magento\Framework\Event\ObserverInterface;
 
+/**
+ * Class ProductUrlKeyAutogeneratorObserver
+ *
+ * @package Magento\CatalogUrlRewrite\Observer
+ */
 class ProductUrlKeyAutogeneratorObserver implements ObserverInterface
 {
     /**
      * @var \Magento\CatalogUrlRewrite\Model\ProductUrlPathGenerator
      */
-    protected $productUrlPathGenerator;
+    private $productUrlPathGenerator;
 
     /**
      * @param ProductUrlPathGenerator $productUrlPathGenerator
@@ -26,12 +30,16 @@ public function __construct(ProductUrlPathGenerator $productUrlPathGenerator)
     }
 
     /**
-     * @param \Magento\Framework\Event\Observer $observer
+     * Generate url_key and set it on the Product
+     *
+     * @param  \Magento\Framework\Event\Observer $observer
      * @return void
      */
     public function execute(\Magento\Framework\Event\Observer $observer)
     {
-        /** @var Product $product */
+        /**
+         * @var Product $product
+         */
         $product = $observer->getEvent()->getProduct();
         $urlKey = $this->productUrlPathGenerator->getUrlKey($product);
         if (null !== $urlKey) {

app/code/Magento/CatalogUrlRewrite/etc/webapi_rest/events.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
+    <event name="catalog_product_save_before">
+        <observer name="product_save_rewrites_history_setter" instance="Magento\CatalogUrlRewrite\Observer\ProductSaveRewritesHistorySetterObserver"/>
+    </event>
+</config>

app/code/Magento/CatalogUrlRewrite/etc/webapi_soap/events.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
+    <event name="catalog_product_save_before">
+        <observer name="product_save_rewrites_history_setter" instance="Magento\CatalogUrlRewrite\Observer\ProductSaveRewritesHistorySetterObserver"/>
+    </event>
+</config>