Skip to content

Commit a8ffede

Browse files
committed
MC-20636: Order Details : Order Details by Order Number
- fix test - fix static
1 parent 5e2f443 commit a8ffede

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/code/Magento/SalesGraphQl/Model/Resolver/OrderTotal.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ private function getAllAppliedTaxesForItems(array $itemAppliedTaxes): array
9393
/**
9494
* Retrieve applied taxes that apply to shipping
9595
*
96-
* @param \Magento\Tax\Api\Data\OrderTaxDetailsItemInterface $extensionAttributes
96+
* @param \Magento\Tax\Api\Data\OrderTaxDetailsItemInterface $itemAppliedTaxes
9797
* @return array
9898
*/
9999
private function getAppliedShippingTaxesForItems(array $itemAppliedTaxes): array
@@ -125,7 +125,7 @@ private function getShippingDiscountDetails(OrderInterface $order)
125125
if (!($order->getDiscountDescription() === null && $order->getShippingDiscountAmount() == 0)) {
126126
$shippingDiscounts[] =
127127
[
128-
'label' => $order->getDiscountDescription() ?? "null",
128+
'label' => $order->getDiscountDescription() ?? __('Discount'),
129129
'amount' => [
130130
'value' => $order->getShippingDiscountAmount(),
131131
'currency' => $order->getOrderCurrencyCode()
@@ -146,7 +146,7 @@ private function getDiscountDetails(OrderInterface $order)
146146
$discounts = [];
147147
if (!($order->getDiscountDescription() === null && $order->getDiscountAmount() == 0)) {
148148
$discounts[] = [
149-
'label' => $order->getDiscountDescription() ?? __("Discount"),
149+
'label' => $order->getDiscountDescription() ?? __('Discount'),
150150
'amount' => [
151151
'value' => $order->getDiscountAmount(),
152152
'currency' => $order->getOrderCurrencyCode()

dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/RetrieveOrdersWithBundleProductByOrderNumberTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
use Magento\TestFramework\TestCase\GraphQlAbstract;
2020

2121
/**
22-
* Class RetrieveOrdersWithBundleProductByOrderNumberTest
22+
* Test for orders with bundle product
2323
*/
2424
class RetrieveOrdersWithBundleProductByOrderNumberTest extends GraphQlAbstract
2525
{

0 commit comments

Comments
 (0)