Skip to content

Commit b444002

Browse files
author
Zach Nanninga
committed
ISSUE-28656 - Add frontend area (allowed) to existing isAllowed scenarios, and add scenarios for all other areas where other enabled checks are true
1 parent 35f7e8d commit b444002

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

lib/internal/Magento/Framework/Translate/Test/Unit/InlineTest.php

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,13 @@ protected function setUp(): void
7474
* @param bool $isEnabled
7575
* @param bool $isActive
7676
* @param bool $isDevAllowed
77+
* @param string $area
7778
* @param bool $result
7879
* @dataProvider isAllowedDataProvider
7980
*/
80-
public function testIsAllowed($isEnabled, $isActive, $isDevAllowed, $result)
81+
public function testIsAllowed($isEnabled, $isActive, $isDevAllowed, $area, $result)
8182
{
82-
$this->prepareIsAllowed($isEnabled, $isActive, $isDevAllowed);
83+
$this->prepareIsAllowed($isEnabled, $isActive, $isDevAllowed, null, $area);
8384

8485
$model = new Inline(
8586
$this->scopeResolverMock,
@@ -101,14 +102,21 @@ public function testIsAllowed($isEnabled, $isActive, $isDevAllowed, $result)
101102
public function isAllowedDataProvider()
102103
{
103104
return [
104-
[true, true, true, true],
105-
[true, false, true, false],
106-
[true, true, false, false],
107-
[true, false, false, false],
108-
[false, true, true, false],
109-
[false, false, true, false],
110-
[false, true, false, false],
111-
[false, false, false, false],
105+
[true, true, true, Area::AREA_FRONTEND, true],
106+
[true, false, true, Area::AREA_FRONTEND, false],
107+
[true, true, false, Area::AREA_FRONTEND, false],
108+
[true, false, false, Area::AREA_FRONTEND, false],
109+
[false, true, true, Area::AREA_FRONTEND, false],
110+
[false, false, true, Area::AREA_FRONTEND, false],
111+
[false, true, false, Area::AREA_FRONTEND, false],
112+
[false, false, false, Area::AREA_FRONTEND, false],
113+
[true, true, true, Area::AREA_GLOBAL, false],
114+
[true, true, true, Area::AREA_ADMINHTML, true],
115+
[true, true, true, Area::AREA_DOC, false],
116+
[true, true, true, Area::AREA_CRONTAB, false],
117+
[true, true, true, Area::AREA_WEBAPI_REST, false],
118+
[true, true, true, Area::AREA_WEBAPI_SOAP, false],
119+
[true, true, true, Area::AREA_GRAPHQL, false]
112120
];
113121
}
114122

0 commit comments

Comments
 (0)