Skip to content

Commit cd24e41

Browse files
novikornovikor
committed
Grid Export rendered data is not reflecting in the exported File, Displayed ID instead of Rendered Label #25963.
Unit tests code reformatting.
1 parent 9bb416f commit cd24e41

File tree

1 file changed

+97
-84
lines changed

1 file changed

+97
-84
lines changed

‎app/code/Magento/Ui/Test/Unit/Model/Export/MetadataProviderTest.php

Lines changed: 97 additions & 84 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,29 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
67
namespace Magento\Ui\Test\Unit\Model\Export;
78

9+
use Magento\Framework\Api\AttributeInterface;
810
use Magento\Framework\Api\Search\DocumentInterface;
11+
use Magento\Framework\DataObject;
12+
use Magento\Framework\Exception\LocalizedException;
913
use Magento\Framework\Locale\ResolverInterface;
1014
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
1115
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
1216
use Magento\Framework\View\Element\UiComponentInterface;
17+
use Magento\Ui\Component\Filters;
18+
use Magento\Ui\Component\Filters\Type\Select;
1319
use Magento\Ui\Component\Listing\Columns;
1420
use Magento\Ui\Component\Listing\Columns\Column;
1521
use Magento\Ui\Component\MassAction\Filter;
1622
use Magento\Ui\Model\Export\MetadataProvider;
23+
use PHPUnit\Framework\TestCase;
1724

1825
/**
1926
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
2027
*/
21-
class MetadataProviderTest extends \PHPUnit\Framework\TestCase
28+
class MetadataProviderTest extends TestCase
2229
{
2330
/**
2431
* @var MetadataProvider
@@ -45,25 +52,25 @@ class MetadataProviderTest extends \PHPUnit\Framework\TestCase
4552
*/
4653
protected function setUp()
4754
{
48-
$this->filter = $this->getMockBuilder(\Magento\Ui\Component\MassAction\Filter::class)
49-
->disableOriginalConstructor()
50-
->getMock();
55+
$this->filter = $this->getMockBuilder(Filter::class)
56+
->disableOriginalConstructor()
57+
->getMock();
5158

52-
$this->localeDate = $this->getMockBuilder(\Magento\Framework\Stdlib\DateTime\TimezoneInterface::class)
53-
->disableOriginalConstructor()
54-
->getMock();
59+
$this->localeDate = $this->getMockBuilder(TimezoneInterface::class)
60+
->disableOriginalConstructor()
61+
->getMock();
5562

56-
$this->localeResolver = $this->getMockBuilder(\Magento\Framework\Locale\ResolverInterface::class)
57-
->disableOriginalConstructor()
58-
->getMock();
63+
$this->localeResolver = $this->getMockBuilder(ResolverInterface::class)
64+
->disableOriginalConstructor()
65+
->getMock();
5966

6067
$this->localeResolver->expects($this->any())
61-
->method('getLocale')
62-
->willReturn(null);
68+
->method('getLocale')
69+
->willReturn(null);
6370

6471
$objectManager = new ObjectManager($this);
6572
$this->model = $objectManager->getObject(
66-
\Magento\Ui\Model\Export\MetadataProvider::class,
73+
MetadataProvider::class,
6774
[
6875
'filter' => $this->filter,
6976
'localeDate' => $this->localeDate,
@@ -99,12 +106,12 @@ public function testGetHeaders(array $columnLabels, array $expected): void
99106
public function getColumnsDataProvider(): array
100107
{
101108
return [
102-
[['ID'],['ID']],
103-
[['Name'],['Name']],
104-
[['Id'],['Id']],
105-
[['id'],['id']],
106-
[['IDTEST'],['IDTEST']],
107-
[['ID TEST'],['ID TEST']],
109+
[['ID'], ['ID']],
110+
[['Name'], ['Name']],
111+
[['Id'], ['Id']],
112+
[['id'], ['id']],
113+
[['IDTEST'], ['IDTEST']],
114+
[['ID TEST'], ['ID TEST']],
108115
];
109116
}
110117

@@ -128,6 +135,7 @@ public function testGetFields()
128135
* @param string $columnLabel
129136
* @param string $columnActionsName
130137
* @param string $columnActionsLabel
138+
*
131139
* @return UiComponentInterface|\PHPUnit_Framework_MockObject_MockObject
132140
*/
133141
protected function prepareColumns(
@@ -138,57 +146,57 @@ protected function prepareColumns(
138146
$columnActionsLabel = 'actions_label'
139147
) {
140148
/** @var UiComponentInterface|\PHPUnit_Framework_MockObject_MockObject $component */
141-
$component = $this->getMockBuilder(\Magento\Framework\View\Element\UiComponentInterface::class)
142-
->getMockForAbstractClass();
149+
$component = $this->getMockBuilder(UiComponentInterface::class)
150+
->getMockForAbstractClass();
143151

144152
/** @var Columns|\PHPUnit_Framework_MockObject_MockObject $columns */
145-
$columns = $this->getMockBuilder(\Magento\Ui\Component\Listing\Columns::class)
146-
->disableOriginalConstructor()
147-
->getMock();
153+
$columns = $this->getMockBuilder(Columns::class)
154+
->disableOriginalConstructor()
155+
->getMock();
148156

149157
/** @var Column|\PHPUnit_Framework_MockObject_MockObject $column */
150-
$column = $this->getMockBuilder(\Magento\Ui\Component\Listing\Columns\Column::class)
151-
->disableOriginalConstructor()
152-
->getMock();
158+
$column = $this->getMockBuilder(Column::class)
159+
->disableOriginalConstructor()
160+
->getMock();
153161
/** @var Column|\PHPUnit_Framework_MockObject_MockObject $columnActions */
154-
$columnActions = $this->getMockBuilder(\Magento\Ui\Component\Listing\Columns\Column::class)
155-
->disableOriginalConstructor()
156-
->getMock();
162+
$columnActions = $this->getMockBuilder(Column::class)
163+
->disableOriginalConstructor()
164+
->getMock();
157165

158166
$component->expects($this->any())
159-
->method('getName')
160-
->willReturn($componentName);
167+
->method('getName')
168+
->willReturn($componentName);
161169
$component->expects($this->atLeastOnce())
162-
->method('getChildComponents')
163-
->willReturn([$columns]);
170+
->method('getChildComponents')
171+
->willReturn([$columns]);
164172

165173
$columns->expects($this->atLeastOnce())
166-
->method('getChildComponents')
167-
->willReturn([$column, $columnActions]);
174+
->method('getChildComponents')
175+
->willReturn([$column, $columnActions]);
168176

169177
$column->expects($this->any())
170-
->method('getName')
171-
->willReturn($columnName);
178+
->method('getName')
179+
->willReturn($columnName);
172180
$column->expects($this->any())
173-
->method('getData')
174-
->willReturnMap(
175-
[
176-
['config/label', null, $columnLabel],
177-
['config/dataType', null, 'data_type'],
178-
]
179-
);
181+
->method('getData')
182+
->willReturnMap(
183+
[
184+
['config/label', null, $columnLabel],
185+
['config/dataType', null, 'data_type'],
186+
]
187+
);
180188

181189
$columnActions->expects($this->any())
182-
->method('getName')
183-
->willReturn($columnActionsName);
190+
->method('getName')
191+
->willReturn($columnActionsName);
184192
$columnActions->expects($this->any())
185-
->method('getData')
186-
->willReturnMap(
187-
[
188-
['config/label', null, $columnActionsLabel],
189-
['config/dataType', null, 'actions'],
190-
]
191-
);
193+
->method('getData')
194+
->willReturnMap(
195+
[
196+
['config/label', null, $columnActionsLabel],
197+
['config/dataType', null, 'actions'],
198+
]
199+
);
192200

193201
return $component;
194202
}
@@ -198,25 +206,26 @@ protected function prepareColumns(
198206
* @param array $fields
199207
* @param array $options
200208
* @param array $expected
209+
*
201210
* @dataProvider getRowDataProvider
202211
*/
203212
public function testGetRowData($key, $fields, $options, $expected)
204213
{
205214
/** @var DocumentInterface|\PHPUnit_Framework_MockObject_MockObject $document */
206-
$document = $this->getMockBuilder(\Magento\Framework\Api\Search\DocumentInterface::class)
207-
->getMockForAbstractClass();
215+
$document = $this->getMockBuilder(DocumentInterface::class)
216+
->getMockForAbstractClass();
208217

209-
$attribute = $this->getMockBuilder(\Magento\Framework\Api\AttributeInterface::class)
210-
->getMockForAbstractClass();
218+
$attribute = $this->getMockBuilder(AttributeInterface::class)
219+
->getMockForAbstractClass();
211220

212221
$document->expects($this->once())
213-
->method('getCustomAttribute')
214-
->with($fields[0])
215-
->willReturn($attribute);
222+
->method('getCustomAttribute')
223+
->with($fields[0])
224+
->willReturn($attribute);
216225

217226
$attribute->expects($this->once())
218-
->method('getValue')
219-
->willReturn($key);
227+
->method('getValue')
228+
->willReturn($key);
220229

221230
$result = $this->model->getRowData($document, $fields, $options);
222231
$this->assertTrue(is_array($result));
@@ -271,15 +280,15 @@ public function getRowDataProvider()
271280
* @param array $expected
272281
*
273282
* @dataProvider getOptionsDataProvider
274-
* @throws \Magento\Framework\Exception\LocalizedException
283+
* @throws LocalizedException
275284
*/
276285
public function testGetOptions($filter, $options, $expected)
277286
{
278287
$component = $this->prepareColumnsWithOptions($filter, $options);
279288

280289
$this->filter->expects($this->exactly(2))
281-
->method('getComponent')
282-
->willReturn($component);
290+
->method('getComponent')
291+
->willReturn($component);
283292

284293
$result = $this->model->getOptions();
285294
$this->assertTrue(is_array($result));
@@ -288,32 +297,35 @@ public function testGetOptions($filter, $options, $expected)
288297
}
289298

290299
/**
300+
* @param string $filter
301+
* @param array $options
302+
*
291303
* @return UiComponentInterface|\PHPUnit_Framework_MockObject_MockObject
292304
*/
293305
protected function prepareColumnsWithOptions(string $filter, array $options)
294306
{
295307
/** @var UiComponentInterface|\PHPUnit_Framework_MockObject_MockObject $component */
296-
$component = $this->getMockBuilder(\Magento\Framework\View\Element\UiComponentInterface::class)
308+
$component = $this->getMockBuilder(UiComponentInterface::class)
297309
->getMockForAbstractClass();
298310

299-
$listingTopComponent = $this->getMockBuilder(\Magento\Framework\View\Element\UiComponentInterface::class)
300-
->getMockForAbstractClass();
311+
$listingTopComponent = $this->getMockBuilder(UiComponentInterface::class)
312+
->getMockForAbstractClass();
301313

302-
$filters = $this->getMockBuilder(\Magento\Ui\Component\Filters::class)
314+
$filters = $this->getMockBuilder(Filters::class)
303315
->disableOriginalConstructor()
304316
->getMock();
305317

306318
/** @var Columns|\PHPUnit_Framework_MockObject_MockObject $columns */
307-
$columns = $this->getMockBuilder(\Magento\Ui\Component\Listing\Columns::class)
319+
$columns = $this->getMockBuilder(Columns::class)
308320
->disableOriginalConstructor()
309321
->getMock();
310322

311323
/** @var Column|\PHPUnit_Framework_MockObject_MockObject $column */
312-
$column = $this->getMockBuilder(\Magento\Ui\Component\Listing\Columns\Column::class)
324+
$column = $this->getMockBuilder(Column::class)
313325
->disableOriginalConstructor()
314326
->getMock();
315327
/** @var Column|\PHPUnit_Framework_MockObject_MockObject $columnActions */
316-
$columnActions = $this->getMockBuilder(\Magento\Ui\Component\Listing\Columns\Column::class)
328+
$columnActions = $this->getMockBuilder(Column::class)
317329
->disableOriginalConstructor()
318330
->getMock();
319331

@@ -328,7 +340,7 @@ protected function prepareColumnsWithOptions(string $filter, array $options)
328340
->method('getChildComponents')
329341
->willReturn([$filters]);
330342

331-
$select = $this->getMockBuilder(\Magento\Ui\Component\Filters\Type\Select::class)
343+
$select = $this->getMockBuilder(Select::class)
332344
->disableOriginalConstructor()
333345
->getMock();
334346

@@ -446,29 +458,30 @@ public function getOptionsDataProvider()
446458
*
447459
* @param string $fieldValue
448460
* @param string $expected
461+
*
449462
* @dataProvider convertDateProvider
450463
* @covers \Magento\Ui\Model\Export\MetadataProvider::convertDate()
451464
*/
452465
public function testConvertDate($fieldValue, $expected)
453466
{
454467
$componentName = 'component_name';
455468
/** @var DocumentInterface|\PHPUnit_Framework_MockObject_MockObject $document */
456-
$document = $this->getMockBuilder(\Magento\Framework\DataObject::class)
457-
->disableOriginalConstructor()
458-
->getMock();
469+
$document = $this->getMockBuilder(DataObject::class)
470+
->disableOriginalConstructor()
471+
->getMock();
459472

460473
$document->expects($this->once())
461-
->method('getData')
462-
->with('field')
463-
->willReturn($fieldValue);
474+
->method('getData')
475+
->with('field')
476+
->willReturn($fieldValue);
464477

465478
$this->localeDate->expects($this->once())
466-
->method('date')
467-
->willReturn(new \DateTime($fieldValue, new \DateTimeZone('UTC')));
479+
->method('date')
480+
->willReturn(new \DateTime($fieldValue, new \DateTimeZone('UTC')));
468481

469482
$document->expects($this->once())
470-
->method('setData')
471-
->with('field', $expected);
483+
->method('setData')
484+
->with('field', $expected);
472485

473486
$this->model->convertDate($document, $componentName);
474487
}

0 commit comments

Comments
 (0)