Skip to content

Commit e7b3b4d

Browse files
Implemented code review recommendation
1 parent 3682d87 commit e7b3b4d

File tree

3 files changed

+35
-6
lines changed

3 files changed

+35
-6
lines changed

app/code/Magento/Msrp/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ Attribute group - `Advanced Pricing`.
1313
- `msrp` - Manufacturer's Suggested Retail Price
1414
- `msrp_display_actual_price_type` -Display Actual Price
1515

16-
Before disabling or uninstalling this module, note that the following modules depends on this module:
17-
18-
- `Magento_MsrpConfigurableProduct`
19-
- `Magento_MsrpGroupedProduct`
20-
- `Magento_ConfigurableProduct`
16+
**Pay attention** if described attributes not removed when the module is removed/disabled, it would trigger errors
17+
because they use models and blocks from Magento_Msrp module:
18+
- `\Magento\Msrp\Block\Adminhtml\Product\Helper\Form\Type`
19+
- `\Magento\Msrp\Model\Product\Attribute\Source\Type\Price`
20+
- `\Magento\Msrp\Block\Adminhtml\Product\Helper\Form\Type\Price`
2121

2222
For information about a module installation in Magento 2, see [Enable or disable modules](https://devdocs.magento.com/guides/v2.4/install-gde/install/cli/install-cli-subcommands-enable.html).
2323

app/code/Magento/Multishipping/README.md

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Yo can check this configuration and find more examples in the `etc/frontend/di.x
3232
More information about [type configuration](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/build/di-xml-file.html).
3333

3434

35-
Extension developers can interact with the Magento_Msrp module. For more information about the Magento extension mechanism, see [Magento plug-ins](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/plugins.html).
35+
Extension developers can interact with the Magento_Multishipping module. For more information about the Magento extension mechanism, see [Magento plug-ins](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/plugins.html).
3636

3737
[The Magento dependency injection mechanism](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/depend-inj.html) enables you to override the functionality of the Magento_Msrp module.
3838

@@ -44,6 +44,31 @@ This module observes the following event:
4444

4545
- `checkout_cart_save_before` in the `Magento\Multishipping\Observer\DisableMultishippingObserver` file.
4646

47+
The module dispatches the following events:
48+
49+
- `multishipping_checkout_controller_success_action` event in the
50+
class `\Magento\Multishipping\Controller\Checkout\Success::execute()` method. Parameters:
51+
- `order_ids` is order ids created during checkout
52+
- `checkout_controller_multishipping_shipping_post` event in the
53+
class `\Magento\Multishipping\Controller\Checkout\ShippingPost::execute()` method. Parameters:
54+
- `request` is a request object `Magento\Framework\App\RequestInterface`.
55+
- `quote` is a quote object for current checkout `Magento\Quote\Model\Quote`.
56+
- `checkout_type_multishipping_set_shipping_items` event in the
57+
class `\Magento\Multishipping\Model\Checkout\Type\Multishipping::setShippingItemsInformation()` method. Parameters:
58+
- `quote` is a quote object for current checkout `Magento\Quote\Model\Quote`.
59+
- `checkout_type_multishipping_create_orders_single` event in the
60+
class `\Magento\Multishipping\Model\Checkout\Type\Multishipping::createOrders()` method. Parameters:
61+
- `order` is a prepared order object for creating `\Magento\Sales\Model\Order`.
62+
- `address` is an address array.
63+
- `quote` is a quote object for current checkout `Magento\Quote\Model\Quote`.
64+
- `checkout_submit_all_after` event in the
65+
class `\Magento\Multishipping\Model\Checkout\Type\Multishipping::createOrders()` method. Parameters:
66+
- `orders` is order object array `\Magento\Sales\Model\Order` that was created.
67+
- `quote` is a quote object for current checkout `Magento\Quote\Model\Quote`.
68+
- `checkout_multishipping_refund_all` event in the
69+
class `\Magento\Multishipping\Model\Checkout\Type\Multishipping::createOrders()` method. Parameters:
70+
- `orders` is order object array `\Magento\Sales\Model\Order` that was created.
71+
4772
For information about an event in Magento 2, see [Events and observers](http://devdocs.magento.com/guides/v2.3/extension-dev-guide/events-and-observers.html#events).
4873

4974
### Layouts

app/code/Magento/MysqlMq/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
**Magento_MysqlMq** provides message queue implementation based on MySQL.
44

5+
Module contain recurring script, declared in `Magento\MysqlMq\Setup\Recurring`
6+
class. This script is executed by Magento post each schema installation or upgrade
7+
stage and populates the queue table.
8+
59
## Installation
610

711
Module creates the following tables:

0 commit comments

Comments
 (0)