Skip to content

Commit ee6436f

Browse files
ENGCOM-8152: ui select list visible even though it is disabled #27896
- Merge Pull Request #27896 from Mohamed-Asar/magento2:ui-select-list-visible-bug - Merged commits: 1. 6ba9fff 2. 2e75bae 3. 66ee024
2 parents 1c9ba3e + 66ee024 commit ee6436f

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

app/code/Magento/Ui/view/base/web/js/form/element/ui-select.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,7 @@ define([
668668
* @returns {Object} Chainable
669669
*/
670670
toggleListVisible: function () {
671-
this.listVisible(!this.listVisible());
671+
this.listVisible(!this.disabled() && !this.listVisible());
672672

673673
return this;
674674
},

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/form/ui-select.test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,12 @@ define([
246246

247247
expect(type).toEqual('object');
248248
});
249+
it('Must be false if "disabled" is true', function () {
250+
obj.listVisible(false);
251+
obj.disabled(true);
252+
obj.toggleListVisible();
253+
expect(obj.listVisible()).toEqual(false);
254+
});
249255
it('Must be false if "listVisible" is true', function () {
250256
obj.listVisible(true);
251257
obj.toggleListVisible();

0 commit comments

Comments
 (0)