#33334:Inheriting from a class that doesn't exist

- Adjusted code style for the unit test
- Replaced FQPN using import

Author: monteshot

app/code/Magento/Bundle/Pricing/Price/ConfiguredPrice.php

@@ -49,7 +49,7 @@ class ConfiguredPrice extends CatalogPrice\FinalPrice implements ConfiguredPrice
      */
     private $configuredPriceSelection;
     /**
-     * @var \Magento\Bundle\Pricing\Price\DiscountCalculator
+     * @var DiscountCalculator
      */
     private $discountCalculator;
 

app/code/Magento/Bundle/Test/Unit/Pricing/Price/ConfiguredPriceTest.php

@@ -10,9 +10,6 @@
 use Magento\Bundle\Pricing\Price\DiscountCalculator;
 use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\Product\Configuration\Item\ItemInterface;
-use Magento\Catalog\Model\Product\Configuration\Item\Option\OptionInterface;
-use Magento\Catalog\Model\Product\Option;
-use Magento\Catalog\Model\Product\Option\Type\DefaultType;
 use Magento\Bundle\Pricing\Price\ConfiguredPrice;
 use Magento\Bundle\Pricing\Adjustment\Calculator;
 use Magento\Catalog\Pricing\Price\ConfiguredPriceSelection;
@@ -33,53 +30,57 @@ class ConfiguredPriceTest extends TestCase
     /**
      * @var float
      */
-    protected $basePriceValue = 100.;
+    private $basePriceValue = 100.;
 
     /**
-     * @var MockObject
+     * @var ItemInterface|MockObject
      */
-    protected $item;
+    private $itemMock;
 
     /**
-     * @var MockObject
+     * @var Product|MockObject
      */
-    protected $product;
+    private $productMock;
 
     /**
      * @var MockObject
      */
-    protected $calculator;
+    private $calculator;
 
     /**
-     * @var MockObject
+     * @var Base|MockObject
      */
-    protected $priceInfo;
+    private $priceInfoMock;
 
     /**
      * @var ConfiguredPrice
      */
-    protected $model;
+    private $model;
 
     /**
      * @var PriceCurrencyInterface|MockObject
      */
-    protected $priceCurrencyMock;
+    private $priceCurrencyMock;
+
     /**
      * @var Json|MockObject
      */
     private $jsonSerializerMock;
+
     /**
      * @var ConfiguredPriceSelection|MockObject
      */
     private $configuredPriceSelectionMock;
+
     /**
      * @var AmountInterface|MockObject
      */
     private $amountInterfaceMock;
+
     /**
      * @var DiscountCalculator|MockObject
      */
-    private $discountCalculator;
+    private $discountCalculatorMock;
 
     /**
      * Initialize base dependencies
@@ -89,18 +90,18 @@ protected function setUp(): void
         $basePrice = $this->getMockForAbstractClass(PriceInterface::class);
         $basePrice->expects($this->any())->method('getValue')->willReturn($this->basePriceValue);
 
-        $this->priceInfo = $this->createMock(Base::class);
-        $this->priceInfo->expects($this->any())->method('getPrice')->willReturn($basePrice);
-        $this->product = $this->getMockBuilder(Product::class)
+        $this->priceInfoMock = $this->createMock(Base::class);
+        $this->priceInfoMock->expects($this->any())->method('getPrice')->willReturn($basePrice);
+        $this->productMock = $this->getMockBuilder(Product::class)
             ->setMethods(['getPriceInfo', 'getOptionById', 'getResource', 'getId'])
             ->disableOriginalConstructor()
             ->getMock();
-        $this->product->expects($this->once())->method('getPriceInfo')->willReturn($this->priceInfo);
-        $this->product->expects($this->any())->method('getId')->willReturn(123);
+        $this->productMock->expects($this->once())->method('getPriceInfo')->willReturn($this->priceInfoMock);
+        $this->productMock->expects($this->any())->method('getId')->willReturn(123);
 
-        $this->item = $this->getMockBuilder(ItemInterface::class)
+        $this->itemMock = $this->getMockBuilder(ItemInterface::class)
             ->getMock();
-        $this->item->expects($this->any())->method('getProduct')->willReturn($this->product);
+        $this->itemMock->expects($this->any())->method('getProduct')->willReturn($this->productMock);
 
         $this->priceCurrencyMock = $this->getMockForAbstractClass(PriceCurrencyInterface::class);
 
@@ -120,42 +121,28 @@ protected function setUp(): void
             ->getMock();
         $this->calculator->expects($this->any())->method('calculateBundleAmount')
             ->willReturn($this->amountInterfaceMock);
-        $this->discountCalculator = $this->getMockBuilder(DiscountCalculator::class)
+        $this->discountCalculatorMock = $this->getMockBuilder(DiscountCalculator::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->discountCalculator->expects($this->any())->method('calculateDiscount')
+        $this->discountCalculatorMock->expects($this->any())->method('calculateDiscount')
             ->willReturn(-5.0);
         $this->model = new ConfiguredPrice(
-            $this->product,
+            $this->productMock,
             1,
             $this->calculator,
             $this->priceCurrencyMock,
             null,
             $this->jsonSerializerMock,
             $this->configuredPriceSelectionMock,
-            $this->discountCalculator,
+            $this->discountCalculatorMock,
         );
-        $this->model->setItem($this->item);
-    }
-
-    private function prepareAndReturnSelectionPriceDataStub()
-    {
-        $first = new DataObject();
-        $first->setValue(2);
-        $first->setQuantity(1);
-        $second = new DataObject();
-        $second->setValue(3);
-        $second->setQuantity(1);
-        return [
-            $first,
-            $second
-        ];
+        $this->model->setItem($this->itemMock);
     }
 
     /**
      * Test of value getter when item presented
      */
-    public function testGetValueMethod()
+    public function testGetValueMethod(): void
     {
         $valueFromMock = $this->model->getValue();
         $this->assertEquals(95., $valueFromMock);
@@ -164,19 +151,35 @@ public function testGetValueMethod()
     /**
      * Test of value getter if no product item
      */
-    public function testGetValueMethodNoItem()
+    public function testGetValueMethodNoItem(): void
     {
-        unset($this->item);
-        $this->product = $this->getMockBuilder(Product::class)
-            //->setMethods(['getPriceInfo', 'getOptionById', 'getResource', 'getId'])
+        $this->productMock = $this->getMockBuilder(Product::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->item = $this->getMockBuilder(ItemInterface::class)
+        $this->itemMock = $this->getMockBuilder(ItemInterface::class)
             ->getMock();
-        $this->item->expects($this->any())->method('getProduct')->willReturn($this->product);
-        $this->product->expects($this->any())->method('getId')->willReturn(false);
-        $this->model->setItem($this->item);
+        $this->itemMock->expects($this->any())->method('getProduct')->willReturn($this->productMock);
+        $this->productMock->expects($this->any())->method('getId')->willReturn(false);
+        $this->model->setItem($this->itemMock);
         $valueFromMock = $this->model->getValue();
         $this->assertEquals(100., $valueFromMock);
     }
+
+    /**
+     * Stub data for calculation amount of bundle
+     * @return \Magento\Framework\DataObject[]
+     */
+    private function prepareAndReturnSelectionPriceDataStub(): array
+    {
+        $first = new DataObject();
+        $first->setValue(2);
+        $first->setQuantity(1);
+        $second = new DataObject();
+        $second->setValue(3);
+        $second->setQuantity(1);
+        return [
+            $first,
+            $second
+        ];
+    }
 }