gitignore for files and folders generated by Magento Functional Testing Framework (MFTF) #30107

lfluvisotto · 2020-09-18T14:35:40Z

Description (*)

When we execute the commands related on https://devdocs.magento.com/mftf/docs/commands/mftf.html

Folders and files will be created during execution of MFTF commands.

In my opinion the changes on those folders and files should not be staged for commit.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

vendor/bin/mftf build:project
vendor/bin/mftf generate:tests

Questions or comments

N/A

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] gitignore for files and folders generated by Magento Functional Testing Framework (MFTF) #30135: gitignore for files and folders generated by Magento Functional Testing Framework (MFTF)

m2-assistant · 2020-09-18T14:35:43Z

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

lfluvisotto · 2020-09-18T14:44:46Z

@ihor-sviziev if you could have a look at PR, I'd appreciate that, let me know if you have any comments or suggestions, thanks.

magento-engcom-team · 2020-09-18T17:52:32Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8233 has been created to process this Pull Request

sidolov · 2020-09-21T15:11:33Z

@magento create issue

hostep · 2020-09-22T19:03:14Z

I think the last two lines should be put in https://github.com/magento/magento2/blob/2.4-develop/dev/tests/acceptance/.gitignore instead of the .gitignore file of the entire project.

There are a whole bunch of .gitignore files in the dev subdirectory for that purpose:

dev/tests/unit/.gitignore
dev/tests/unit/tmp/.gitignore
dev/tests/integration/.gitignore
dev/tests/integration/tmp/.gitignore
dev/tests/acceptance/.gitignore
dev/tests/static/testsuite/Magento/Test/_files/.gitignore
dev/tests/static/.gitignore
dev/tests/static/tmp/.gitignore
dev/tests/api-functional/.gitignore
dev/tests/setup-integration/.gitignore
...

Thoughts?

Also: ignoring the entire dev/tests/acceptance/tests/ directory feels very incorrect, since there are many files already in git from that directory, @lfluvisotto what specific files are being marked in git exactly?

ihor-sviziev · 2020-09-22T19:07:46Z

@hostep oh, you’re right!

ihor-sviziev

Hi @lfluvisotto,
Could you update your PR according to following suggestion #30107 (comment) ?

lfluvisotto · 2020-09-23T15:06:52Z

@ihor-sviziev , @hostep , PR updated

hostep · 2020-09-23T16:06:29Z

Looks good

@ihor-sviziev: is it expected that running the MFTF tests creates a _generated directory in the root of the Magento project? This feels incorrect to me, but I might be wrong ...

ihor-sviziev · 2020-09-23T18:10:07Z

@hostep i do agree with you

@okolesnyk @lbajsarowicz could you provide us some feedback, why the _generated folder is creating in the file reject root? Seems like that’s wrong behavior

lbajsarowicz · 2020-09-23T20:23:22Z

@ihor-sviziev You should be still happy, as some of the files are generated in vendor/... directory 🤣
Change vendor/ directory to Read Only, execute MFTF tests and watch them fail.

ihor-sviziev · 2020-09-24T09:57:22Z

@lbajsarowicz wow 🤦‍♂️ . Do we have a bug on it in the MFTF?

lbajsarowicz · 2020-09-24T10:00:11Z

@ihor-sviziev magento/magento2-functional-testing-framework#699

ihor-sviziev · 2020-09-24T10:01:54Z

@magento run all tests

orlangur

Nevermind

magento-engcom-team · 2020-10-08T12:34:41Z

Hi @orlangur, thank you for the review.
ENGCOM-8233 has been created to process this Pull Request

ihor-sviziev · 2020-10-15T06:41:10Z

@magento run Functional Tests B2B, WebAPI Tests

ihor-sviziev · 2020-10-19T08:33:50Z

@magento run Functional Tests B2B

ihor-sviziev · 2020-11-04T07:39:23Z

@magento run Functional Tests B2B

lfluvisotto · 2022-09-03T00:54:02Z

Hi @ihor-sviziev, this PR is open and approved since September 2020, isn't it gonna be merged?

lfluvisotto · 2022-09-03T00:59:28Z

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Magento Health Index, Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE, Semantic Version Checker, Static Tests, Unit Tests , WebAPI Tests

magento-automated-testing · 2022-09-03T00:59:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2022-09-03T05:15:22Z

@lfluvisotto so far, the only high priority (P0, P1 and P2) pull requests are currently getting processed 🙁

lfluvisotto · 2024-08-19T01:36:33Z

@magento run all tests

…ng Framework (MFTF)

lfluvisotto · 2024-08-19T20:43:41Z

@magento run all tests

lfluvisotto · 2024-08-20T12:19:40Z

@engcom-Delta

engcom-Dash · 2024-10-21T14:08:12Z

Hello @lfluvisotto

Thanks for the contributions!

✔️ QA Passed
Preconditions:

Install fresh Magento 2.4-develop
Steps to reproduce
According to the issue description.

Before: ✖️

_generated folder is visible in git status.

After: ✔️

_generated folder is not visible in git status.

Builds are failed, hence moving it to Extended Testing.

engcom-Dash · 2024-10-21T14:08:39Z

@magento run all tests

engcom-Dash · 2024-10-22T06:18:56Z

@magento run all tests

engcom-Dash · 2024-10-22T08:42:53Z

@magento run Unit Tests, Functional Tests CE

engcom-Dash · 2024-10-22T10:31:51Z

The Functional CE test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30107/1e0ffd99ee07a604cdeb8594e2e2a75c/Functional/allure-report-ce/index.html#categories/8e2b61f028e5c19ee17f4a30e7a11231/e7f6001bd601f0e/

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30107/bae9cda4e82d9e6bf29028c27a73eb05/Functional/allure-report-ce/index.html#categories/6ca9d315ebd9ab54dbe1fb9148ebdc1f/35be6f0af80b7f16/

ghost added the Progress: pending review label Sep 18, 2020

magento-engcom-team added the Release Line: 2.4 label Sep 18, 2020

lfluvisotto force-pushed the 2.4-develop-gitignore-mftf branch from e4b825f to cc110d6 Compare September 18, 2020 14:56

ihor-sviziev approved these changes Sep 18, 2020

View reviewed changes

ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 18, 2020

ghost assigned ihor-sviziev Sep 18, 2020

ghost added Progress: ready for testing and removed Progress: pending review labels Sep 18, 2020

sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 21, 2020

m2-assistant bot mentioned this pull request Sep 21, 2020

[Issue] gitignore for files and folders generated by Magento Functional Testing Framework (MFTF) #30135

Open

4 tasks

ihor-sviziev requested changes Sep 22, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: ready for testing labels Sep 22, 2020

lfluvisotto force-pushed the 2.4-develop-gitignore-mftf branch from cc110d6 to cf43e37 Compare September 23, 2020 15:06

ghost added Progress: review and removed Progress: needs update labels Sep 23, 2020

orlangur approved these changes Oct 8, 2020

View reviewed changes

orlangur assigned ihor-sviziev and unassigned orlangur Oct 8, 2020

orlangur requested review from orlangur and removed request for orlangur October 8, 2020 12:35

ihor-sviziev added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Oct 7, 2021

lfluvisotto force-pushed the 2.4-develop-gitignore-mftf branch from d30431b to a3e4f05 Compare August 19, 2024 01:35

gitignore for files and folders generated by Magento Functional Testi…

5da8072

…ng Framework (MFTF)

lfluvisotto force-pushed the 2.4-develop-gitignore-mftf branch from a3e4f05 to 5da8072 Compare August 19, 2024 20:01

Merge branch '2.4-develop' into 2.4-develop-gitignore-mftf

2f4551a

Merge branch '2.4-develop' into 2.4-develop-gitignore-mftf

96fbb18

gitignore for files and folders generated by Magento Functional Testing Framework (MFTF) #30107

Are you sure you want to change the base?

gitignore for files and folders generated by Magento Functional Testing Framework (MFTF) #30107

Uh oh!

Conversation

lfluvisotto commented Sep 18, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Sep 18, 2020

Uh oh!

lfluvisotto commented Sep 18, 2020

Uh oh!

magento-engcom-team commented Sep 18, 2020

Uh oh!

sidolov commented Sep 21, 2020

Uh oh!

hostep commented Sep 22, 2020

Uh oh!

ihor-sviziev commented Sep 22, 2020

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

lfluvisotto commented Sep 23, 2020

Uh oh!

hostep commented Sep 23, 2020

Uh oh!

ihor-sviziev commented Sep 23, 2020

Uh oh!

lbajsarowicz commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev commented Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lbajsarowicz commented Sep 24, 2020

Uh oh!

ihor-sviziev commented Sep 24, 2020

Uh oh!

orlangur left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Oct 8, 2020

Uh oh!

ihor-sviziev commented Oct 15, 2020

Uh oh!

ihor-sviziev commented Oct 19, 2020

Uh oh!

ihor-sviziev commented Nov 4, 2020

Uh oh!

lfluvisotto commented Sep 3, 2022

Uh oh!

lfluvisotto commented Sep 3, 2022

Uh oh!

magento-automated-testing bot commented Sep 3, 2022

Uh oh!

ihor-sviziev commented Sep 3, 2022

Uh oh!

lfluvisotto commented Aug 19, 2024

Uh oh!

lfluvisotto commented Aug 19, 2024

Uh oh!

lfluvisotto commented Aug 20, 2024

Uh oh!

engcom-Dash commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Dash commented Oct 21, 2024

Uh oh!

engcom-Dash commented Oct 22, 2024

Uh oh!

engcom-Dash commented Oct 22, 2024

lfluvisotto commented Sep 18, 2020 •

edited by m2-assistant bot

Loading

lbajsarowicz commented Sep 23, 2020 •

edited

Loading

ihor-sviziev commented Sep 24, 2020 •

edited

Loading

orlangur left a comment •

edited

Loading

engcom-Dash commented Oct 21, 2024 •

edited

Loading