Returning correct FQN class when there is no explicit use in reflected class #36688

MeCapron · 2022-12-30T14:30:42Z

Description (*)

Fixes an issue when no explicit use is defined. When doing so, Magento will return the current class name only without its full namespace which will lead to an error.

Related Pull Requests

Fixed Issues (if relevant)

Fixes DataObjectProcessor reflection is not using FQN for return types #34903

Manual testing scenarios (*)

The manual testing scenario can be found in the issue and has been confirmed by the team.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2022-12-30T14:30:45Z

Hi @MeCapron. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

MeCapron · 2022-12-30T14:31:06Z

@magento run all tests

magento-automated-testing · 2022-12-30T14:31:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

MeCapron · 2022-12-30T15:43:27Z

@magento run all tests

magento-automated-testing · 2022-12-30T15:43:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

MeCapron · 2022-12-30T16:52:43Z

@magento run all tests

magento-automated-testing · 2022-12-30T16:52:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

MeCapron · 2022-12-30T20:47:37Z

@magento run Static Tests

magento-automated-testing · 2022-12-30T20:47:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

MeCapron · 2022-12-31T12:06:48Z

@magento run Static Tests

magento-automated-testing · 2022-12-31T12:06:56Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

MeCapron · 2023-01-01T18:17:38Z

@magento run Static Tests

magento-automated-testing · 2023-01-01T18:17:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

MeCapron · 2023-01-01T19:25:52Z

If someone from the team can tell me why does the static tests are failing ?

1) Magento\Test\Php\LiveCodeTest::testPhpStan
PHPStan detected violation(s):
 ------ ----------------------------------------------------------------------- 
  Line   lib/internal/Magento/Framework/Reflection/Test/Unit/TypeProcessorTest  
         .php                                                                   
 ------ ----------------------------------------------------------------------- 
  165    Class Magento\TestModule1\Service\V1\Entity\Item not found.            
         ðŸ’¡ Learn more at https://phpstan.org/user-guide/discovering-symbols    
 ------ -----------------------------------------------------------------------

I have only updated the test, and the class seem to exist properly.

MeCapron · 2023-01-27T11:03:05Z

@magento run all tests

magento-automated-testing · 2023-01-27T11:03:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Dec 30, 2022

MeCapron force-pushed the 2.4-develop branch from c866814 to 3fddbe1 Compare December 30, 2022 15:42

MeCapron force-pushed the 2.4-develop branch from 3fddbe1 to 4e21f7a Compare December 30, 2022 16:52

MeCapron force-pushed the 2.4-develop branch from 4e21f7a to 9019f1a Compare December 30, 2022 20:47

MeCapron force-pushed the 2.4-develop branch from 9019f1a to ad41907 Compare December 31, 2022 12:05

MeCapron force-pushed the 2.4-develop branch from ad41907 to a58d97b Compare January 1, 2023 18:17

MeCapron closed this Apr 25, 2023

MeCapron force-pushed the 2.4-develop branch from 943d863 to 83b7f30 Compare April 25, 2023 12:46

m2-community-project bot removed the Progress: pending review label Apr 25, 2023

Returning correct FQN class when there is no explicit use in reflected class #36688

Returning correct FQN class when there is no explicit use in reflected class #36688

Uh oh!

Conversation

MeCapron commented Dec 30, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Dec 30, 2022

Uh oh!

MeCapron commented Dec 30, 2022

Uh oh!

magento-automated-testing bot commented Dec 30, 2022

Uh oh!

MeCapron commented Dec 30, 2022

Uh oh!

magento-automated-testing bot commented Dec 30, 2022

Uh oh!

MeCapron commented Dec 30, 2022

Uh oh!

magento-automated-testing bot commented Dec 30, 2022

Uh oh!

MeCapron commented Dec 30, 2022

Uh oh!

magento-automated-testing bot commented Dec 30, 2022

Uh oh!

MeCapron commented Dec 31, 2022

Uh oh!

magento-automated-testing bot commented Dec 31, 2022

Uh oh!

MeCapron commented Jan 1, 2023

Uh oh!

magento-automated-testing bot commented Jan 1, 2023

Uh oh!

MeCapron commented Jan 1, 2023

Uh oh!

MeCapron commented Jan 27, 2023

Uh oh!

magento-automated-testing bot commented Jan 27, 2023

Uh oh!

Uh oh!