Skip to content

Add explanatory titles to cache management buttons #38598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Add explanatory titles to cache management buttons #38598

wants to merge 4 commits into from

Conversation

YevhenZvieriev
Copy link
Contributor

@YevhenZvieriev YevhenZvieriev commented Apr 9, 2024 •
edited
Loading

Description

This Pull Request adds explanatory titles to cache management buttons on the Cache Management page. The added titles provide users with a better understanding of the functionality of each button, making their interaction with the cache management buttons more intuitive. These changes improve the user experience and provide a better understanding of the functionality of cache management buttons on the Magento admin page because at first glance it is not clear what the difference between these two buttons is.

Changes

Added explanatory titles to the Flush Cache Storage and Flush Magento Cache buttons.

The title for the Flush Cache Storage button when you move the cursor over it now explains that it performs similar actions as the bin/magento cache:flush command:
Screenshot from 2024-04-10 02-30-25

The title for the Flush Magento Cache button when you move the cursor over it now explains that it performs actions similar to the bin/magento cache:clean command:

Screenshot from 2024-04-10 02-30-34

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add explanatory titles to cache management buttons #38607: Add explanatory titles to cache management buttons

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 9, 2024

Hi @YevhenZvieriev. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Apr 10, 2024
Open
5 tasks
@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Apr 10, 2024
@YevhenZvieriev
Copy link
Contributor Author

@magento run all tests

@hostep
Copy link
Contributor

hostep commented Jul 2, 2024 •
edited
Loading

I don't think this is a good idea, the admin interface is often used by people who have no idea what bin/magento command is or how they can use it, so these extra titles might confuse them.

If you can find some well written description in English that can explain the difference between the buttons better, without using too many technical terms, then I think it would be better then mentioning developer specific jargon.

But that's just my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Add explanatory titles to cache management buttons
3 participants
@YevhenZvieriev @engcom-Hotel @hostep