Skip to content

Fix overrides.xml #37371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Fix overrides.xml #37371

wants to merge 21 commits into from

Conversation

duhon
Copy link
Contributor

@duhon duhon commented Apr 13, 2023 •
edited by m2-assistant bot
Loading

Without this fix it is impossible to use overrides.xml which declaratively changes the configuration of Magento tests

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. create any Magento module with web-api tests and an overrides.xml file (to suppress the ever-failing Magento tests)
  2. run all API tests and make sure that overrides.xml was ignored by the test framework

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix overrides.xml #39090: Fix overrides.xml

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2023

Hi @duhon. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 18, 2023
@duhon
Copy link
Contributor Author

duhon commented Nov 17, 2023

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@duhon
Copy link
Contributor Author

duhon commented Nov 17, 2023

@engcom-Hotel ping

@duhon
Copy link
Contributor Author

duhon commented Nov 22, 2023

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@duhon duhon added Priority: P0 This generally occurs in cases when the entire functionality is blocked. and removed Priority: P0 This generally occurs in cases when the entire functionality is blocked. labels Nov 30, 2023
@duhon
Copy link
Contributor Author

duhon commented Mar 6, 2024 •
edited
Loading

@engcom-Hotel ping
very easy changes, just changing to the correct type solves an important problem of code quality. Is it really that hard to press merge?

@engcom-Hotel engcom-Hotel self-requested a review March 7, 2024 11:30
@engcom-Hotel
Copy link
Contributor

@magento run all tests

engcom-Hotel
engcom-Hotel requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @duhon,

Thanks for the contribution!

Please fix the failed automated test.

Thanks

@engcom-Delta engcom-Delta added the Project: Community Picked PRs upvoted by the community label Aug 16, 2024
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Aug 19, 2024
@engcom-November
Copy link
Contributor

@magento create issue

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@engcom-Hotel, I have fixed the static test failures hence moving it to Pending Review.

@engcom-Charlie engcom-Charlie moved this from Changes Requested to Pending Review in Community Dashboard Apr 11, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Apr 14, 2025
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B,Functional Tests CE, Functional Tests EE

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Ready for Testing in Community Dashboard Apr 15, 2025
@engcom-Dash engcom-Dash self-assigned this Apr 21, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Testing to Testing in Progress in Community Dashboard Apr 21, 2025
@engcom-Dash
Copy link
Contributor

We are not able to reproduce the issue on 2.4-develop branch. Please find comment: #39090 (comment). Hence Moving this PR on hold for now.

@engcom-Dash engcom-Dash moved this from Testing in Progress to On Hold in Community Dashboard Apr 23, 2025
@engcom-Dash
Copy link
Contributor

Hi @duhon,

As per our conversation on Slack and #37371 (comment) , the issue is not reproducible on the 2.4-develop branch. Therefore, we are closing this PR for now.

Please feel free to reopen it if you have additional information or if the issue persists.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Charlie engcom-Charlie

@engcom-Hotel engcom-Hotel

@engcom-Dash engcom-Dash

Labels
Area: Test framework Component: Framework/TestFramework Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: on hold Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix overrides.xml
7 participants
@duhon @engcom-Hotel @engcom-November @engcom-Charlie @engcom-Dash @engcom-Bravo @engcom-Delta