Skip to content

Commit 5f4777e

Browse files
committed
Add name in TODO
1 parent b14b440 commit 5f4777e

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/attributes.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ pub fn check_tied_features(sess: &Session, features: &FxHashMap<&str, bool>) ->
2525
None
2626
}
2727

28-
// TODO: maybe move to a new module gcc_util.
28+
// TODO(antoyo): maybe move to a new module gcc_util.
2929
// To find a list of GCC's names, check https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html
3030
fn to_gcc_features<'a>(sess: &Session, s: &'a str) -> SmallVec<[&'a str; 2]> {
3131
let arch = if sess.target.arch == "x86_64" { "x86" } else { &*sess.target.arch };
@@ -95,7 +95,7 @@ pub fn from_fn_attrs<'gcc, 'tcx>(
9595
.iter()
9696
.flat_map(|feat| to_gcc_features(cx.tcx.sess, feat).into_iter())
9797
.chain(codegen_fn_attrs.instruction_set.iter().map(|x| match x {
98-
InstructionSetAttr::ArmA32 => "-thumb-mode", // TODO: support removing feature.
98+
InstructionSetAttr::ArmA32 => "-thumb-mode", // TODO(antoyo): support removing feature.
9999
InstructionSetAttr::ArmT32 => "thumb-mode",
100100
}))
101101
.collect::<Vec<_>>();

src/common.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ impl<'gcc, 'tcx> ConstMethods<'tcx> for CodegenCx<'gcc, 'tcx> {
182182
// NOTE: since the intrinsic _xabort is called with a bitcast, which
183183
// is non-const, but expects a constant, do a normal cast instead of a bitcast.
184184
// FIXME(antoyo): fix bitcast to work in constant contexts.
185-
// TODO: perhaps only use bitcast for pointers?
185+
// TODO(antoyo): perhaps only use bitcast for pointers?
186186
self.context.new_cast(None, value, ty)
187187
}
188188
else {

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ pub fn target_features(sess: &Session) -> Vec<Symbol> {
304304
.filter(|_feature| {
305305
// TODO(antoyo): implement a way to get enabled feature in libgccjit.
306306
// Probably using the equivalent of __builtin_cpu_supports.
307-
// TODO: maybe use whatever outputs the following command:
307+
// TODO(antoyo): maybe use whatever outputs the following command:
308308
// gcc -march=native -Q --help=target
309309
#[cfg(feature="master")]
310310
{

0 commit comments

Comments
 (0)