Update to mupdf v1.26.0-rc1 and fix leak (#135)

* Update to mupdf v1.26.0-rc1

* Prevent font buffer from being leaked

* Make llvm-symbolizer available in ASAN CI

* Compile fontconfig in ASAN CI

* Revert "Compile fontconfig in ASAN CI"

This reverts commit 6579d8d.

* Ignore Fc in LSAN

Author: ginnyTheCat

.github/workflows/CI.yml

@@ -95,13 +95,13 @@ jobs:
       - uses: dtolnay/rust-toolchain@nightly
         with:
           components: rust-src
-      - run: sudo apt-get -y install libfontconfig1-dev
+      - run: sudo apt-get -y install libfontconfig1-dev llvm
       - name: cargo test --features serde
         run: |
           cargo test -Zbuild-std --target x86_64-unknown-linux-gnu --features serde
         env:
           RUSTFLAGS: -Zsanitizer=address
-          LSAN_OPTIONS: report_objects=1
+          LSAN_OPTIONS: report_objects=1:suppressions=lsan_suppressions.txt
 
   valgrind:
     name: Valgrind

lsan_suppressions.txt

@@ -0,0 +1,2 @@
+# fontconfig
+leak:Fc

mupdf-sys/mupdf

@@ -80,7 +80,7 @@ impl Font {
                 context(),
                 c_name.as_ptr(),
                 index,
-                buffer.into_inner()
+                buffer.inner
             ))
         }
         .map(|inner| Self { inner })

src/font.rs

@@ -122,8 +122,9 @@ impl StrokeState {
     pub fn dashes(&self) -> Vec<f32> {
         unsafe {
             let dash_len = (*self.inner).dash_len as usize;
+            let dash_ptr = (*self.inner).dash_list.as_ptr();
             let mut dash_list = Vec::with_capacity(dash_len);
-            dash_list.extend_from_slice(&(*self.inner).dash_list[0..dash_len]);
+            dash_list.extend_from_slice(std::slice::from_raw_parts(dash_ptr, dash_len));
             dash_list
         }
     }