feat: capitalise var naming to IDs (#964)

* feat: capitalise var naming to IDs

* feat: added test case for IDs case

Author: VincentBaron

lint/utils.go

@@ -71,6 +71,10 @@ func Name(name string, allowlist, blocklist []string) (should string) {
 			if w == 0 && unicode.IsLower(runes[w]) {
 				u = strings.ToLower(u)
 			}
+			// Keep lowercase s for IDs
+			if u == "IDS" {
+				u = "IDs"
+			}
 			// All the common initialisms are ASCII,
 			// so we can replace the bytes exactly.
 			copy(runes[w:], []rune(u))
@@ -99,6 +103,7 @@ var commonInitialisms = map[string]bool{
 	"HTTP":  true,
 	"HTTPS": true,
 	"ID":    true,
+	"IDS":   true,
 	"IP":    true,
 	"JSON":  true,
 	"LHS":   true,

testdata/var-naming.go

@@ -2,6 +2,7 @@ package fixtures
 
 func foo() string {
 	customId := "result"
-	customVm := "result" // MATCH /var customVm should be customVM/
+	customVm := "result"  // MATCH /var customVm should be customVM/
+	customIds := "result" // MATCH /var customIds should be customIDs/
 	return customId
 }