Adding SyntaxKind.BindingElement case

Author: ahejlsberg

src/compiler/utilities.ts

@@ -1201,9 +1201,10 @@ namespace ts {
                     return parent.kind === SyntaxKind.TypeQuery;
                 }
                 return false;
+            case SyntaxKind.BindingElement:
             case SyntaxKind.ImportSpecifier:
-                // Name on left hand of 'as' in import specifier
-                return (<ImportSpecifier>parent).propertyName === node;
+                // Property name in binding element or import specifier
+                return (<BindingElement | ImportSpecifier>parent).propertyName === node;
             case SyntaxKind.ExportSpecifier:
                 // Any name in an export specifier
                 return true;

tests/baselines/reference/strictModeReservedWordInDestructuring.errors.txt

@@ -3,8 +3,8 @@ tests/cases/compiler/strictModeReservedWordInDestructuring.ts(3,10): error TS121
 tests/cases/compiler/strictModeReservedWordInDestructuring.ts(4,7): error TS1212: Identifier expected. 'private' is a reserved word in strict mode
 tests/cases/compiler/strictModeReservedWordInDestructuring.ts(5,15): error TS1212: Identifier expected. 'static' is a reserved word in strict mode
 tests/cases/compiler/strictModeReservedWordInDestructuring.ts(5,38): error TS1212: Identifier expected. 'package' is a reserved word in strict mode
-tests/cases/compiler/strictModeReservedWordInDestructuring.ts(6,6): error TS1212: Identifier expected. 'public' is a reserved word in strict mode
-tests/cases/compiler/strictModeReservedWordInDestructuring.ts(6,14): error TS1212: Identifier expected. 'protected' is a reserved word in strict mode
+tests/cases/compiler/strictModeReservedWordInDestructuring.ts(6,7): error TS1212: Identifier expected. 'public' is a reserved word in strict mode
+tests/cases/compiler/strictModeReservedWordInDestructuring.ts(6,15): error TS1212: Identifier expected. 'protected' is a reserved word in strict mode
 
 
 ==== tests/cases/compiler/strictModeReservedWordInDestructuring.ts (7 errors) ====
@@ -18,13 +18,15 @@ tests/cases/compiler/strictModeReservedWordInDestructuring.ts(6,14): error TS121
     var [[private]] = [["hello"]];
           ~~~~~~~
 !!! error TS1212: Identifier expected. 'private' is a reserved word in strict mode
-    var { y: { s: static }, z: { o: { p: package} }} = { y: { s: 1 }, z: { o: { p: 'h' } } };
+    var { y: { s: static }, z: { o: { p: package } }} = { y: { s: 1 }, z: { o: { p: 'h' } } };
                   ~~~~~~
 !!! error TS1212: Identifier expected. 'static' is a reserved word in strict mode
                                          ~~~~~~~
 !!! error TS1212: Identifier expected. 'package' is a reserved word in strict mode
-    var {public, protected} = { public: 1, protected: 2 };
-         ~~~~~~
+    var { public, protected } = { public: 1, protected: 2 };
+          ~~~~~~
 !!! error TS1212: Identifier expected. 'public' is a reserved word in strict mode
-                 ~~~~~~~~~
-!!! error TS1212: Identifier expected. 'protected' is a reserved word in strict mode
+                  ~~~~~~~~~
+!!! error TS1212: Identifier expected. 'protected' is a reserved word in strict mode
+    var { public: a, protected: b } = { public: 1, protected: 2 };
+    

tests/baselines/reference/strictModeReservedWordInDestructuring.js

@@ -3,8 +3,10 @@
 var [public] = [1];
 var { x: public } = { x: 1 };
 var [[private]] = [["hello"]];
-var { y: { s: static }, z: { o: { p: package} }} = { y: { s: 1 }, z: { o: { p: 'h' } } };
-var {public, protected} = { public: 1, protected: 2 };
+var { y: { s: static }, z: { o: { p: package } }} = { y: { s: 1 }, z: { o: { p: 'h' } } };
+var { public, protected } = { public: 1, protected: 2 };
+var { public: a, protected: b } = { public: 1, protected: 2 };
+
 
 //// [strictModeReservedWordInDestructuring.js]
 "use strict";
@@ -13,3 +15,4 @@ var public = { x: 1 }.x;
 var private = [["hello"]][0][0];
 var _a = { y: { s: 1 }, z: { o: { p: 'h' } } }, static = _a.y.s, package = _a.z.o.p;
 var _b = { public: 1, protected: 2 }, public = _b.public, protected = _b.protected;
+var _c = { public: 1, protected: 2 }, a = _c.public, b = _c.protected;

tests/cases/compiler/strictModeReservedWordInDestructuring.ts

@@ -2,5 +2,6 @@
 var [public] = [1];
 var { x: public } = { x: 1 };
 var [[private]] = [["hello"]];
-var { y: { s: static }, z: { o: { p: package} }} = { y: { s: 1 }, z: { o: { p: 'h' } } };
-var {public, protected} = { public: 1, protected: 2 };
+var { y: { s: static }, z: { o: { p: package } }} = { y: { s: 1 }, z: { o: { p: 'h' } } };
+var { public, protected } = { public: 1, protected: 2 };
+var { public: a, protected: b } = { public: 1, protected: 2 };