Skip to content

Commit dc451b0

Browse files
committed
Fix for #2268 createDiagnosticCollection should be @internal
DiagnosticsCollection interface is marked @internal in [src/compiler/types.ts](https://github.com/Microsoft/TypeScript/blob/c6cd57d18c85e59b2fbe9d316725748a0af8ac2b/src/compiler/types.ts#L1761), so this should be @internal too. Otherwise it causes compilation errors whenever the generated type definitions for LS is used. See #2268 for more details.
1 parent 848bc87 commit dc451b0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/compiler/utilities.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1207,6 +1207,7 @@ module ts {
12071207
}
12081208
}
12091209

1210+
// @internal
12101211
export function createDiagnosticCollection(): DiagnosticCollection {
12111212
var nonFileDiagnostics: Diagnostic[] = [];
12121213
var fileDiagnostics: Map<Diagnostic[]> = {};
@@ -1336,4 +1337,4 @@ module ts {
13361337
s.replace(nonAsciiCharacters, c => get16BitUnicodeEscapeSequence(c.charCodeAt(0))) :
13371338
s;
13381339
}
1339-
}
1340+
}

0 commit comments

Comments
 (0)