More PR feedback

jakebailey · jakebailey · commit e9a2355e8036 · 2022-01-19T13:14:45.000-08:00
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
@@ -1344,8 +1344,8 @@ namespace ts {
             const child = children[i];
 
             if (isWhiteSpaceOnlyJsxText(child)) {
-                if (parentKind === SyntaxKind.JsxText || parentKind === SyntaxKind.JsxSelfClosingElement) {
-                    Debug.assert(i > 0, "`JsxText` tokens should not be the first child of `JsxElement | JsxSelfClosingElement`");
+                if (i === 0 && (parentKind === SyntaxKind.JsxText || parentKind === SyntaxKind.JsxSelfClosingElement)) {
+                    Debug.fail("`JsxText` tokens should not be the first child of `JsxElement | JsxSelfClosingElement`");
                 }
             }
             else if (nodeHasTokens(children[i], sourceFile)) {

Original file line number	Diff line number	Diff line change
`@@ -1344,8 +1344,8 @@ namespace ts {`
`1344`	`1344`	`const child = children[i];`
`1345`	`1345`
`1346`	`1346`	`if (isWhiteSpaceOnlyJsxText(child)) {`
`1347`		`- if (parentKind === SyntaxKind.JsxText \|\| parentKind === SyntaxKind.JsxSelfClosingElement) {`
`1348`		- Debug.assert(i > 0, "`JsxText` tokens should not be the first child of `JsxElement \| JsxSelfClosingElement`");
	`1347`	`+ if (i === 0 && (parentKind === SyntaxKind.JsxText \|\| parentKind === SyntaxKind.JsxSelfClosingElement)) {`
	`1348`	+ Debug.fail("`JsxText` tokens should not be the first child of `JsxElement \| JsxSelfClosingElement`");
`1349`	`1349`	`}`
`1350`	`1350`	`}`
`1351`	`1351`	`else if (nodeHasTokens(children[i], sourceFile)) {`