PR feedback and fix NewFalseExpression

Author: rbuckton

internal/printer/factory.go

@@ -195,7 +195,7 @@ func (f *NodeFactory) NewTrueExpression() *ast.Expression {
 }
 
 func (f *NodeFactory) NewFalseExpression() *ast.Expression {
-	return f.NewKeywordExpression(ast.KindTrueKeyword)
+	return f.NewKeywordExpression(ast.KindFalseKeyword)
 }
 
 //

internal/printer/printer.go

@@ -5171,7 +5171,7 @@ func (p *Printer) emitLeadingComments(pos int, elided bool) bool {
 	}
 
 	var comments []ast.CommentRange
-	for comment := range scanner.GetLeadingCommentRanges(p.emitContext.Factory, p.currentSourceFile.Text(), pos) {
+	for comment := range scanner.GetLeadingCommentRanges(p.emitContext.Factory.AsNodeFactory(), p.currentSourceFile.Text(), pos) {
 		if p.shouldWriteComment(comment) && p.shouldEmitCommentIfTripleSlash(comment, tripleSlash) {
 			comments = append(comments, comment)
 		}
@@ -5210,7 +5210,7 @@ func (p *Printer) emitTrailingComments(pos int, commentSeparator commentSeparato
 	}
 
 	var comments []ast.CommentRange
-	for comment := range scanner.GetTrailingCommentRanges(p.emitContext.Factory, p.currentSourceFile.Text(), pos) {
+	for comment := range scanner.GetTrailingCommentRanges(p.emitContext.Factory.AsNodeFactory(), p.currentSourceFile.Text(), pos) {
 		if p.shouldWriteComment(comment) {
 			comments = append(comments, comment)
 		}
@@ -5245,15 +5245,15 @@ func (p *Printer) emitDetachedComments(textRange core.TextRange) (result detache
 		//
 		//      var x = 10;
 		if textRange.Pos() == 0 {
-			for comment := range scanner.GetLeadingCommentRanges(p.emitContext.Factory, text, textRange.Pos()) {
+			for comment := range scanner.GetLeadingCommentRanges(p.emitContext.Factory.AsNodeFactory(), text, textRange.Pos()) {
 				if isPinnedComment(text, comment) {
 					leadingComments = append(leadingComments, comment)
 				}
 			}
 		}
 	} else {
 		// removeComments is false, just get detached as normal and bypass the process to filter comment
-		leadingComments = slices.Collect(scanner.GetLeadingCommentRanges(p.emitContext.Factory, text, textRange.Pos()))
+		leadingComments = slices.Collect(scanner.GetLeadingCommentRanges(p.emitContext.Factory.AsNodeFactory(), text, textRange.Pos()))
 	}
 
 	if len(leadingComments) > 0 {

internal/scanner/scanner.go

@@ -2341,11 +2341,11 @@ func ComputePositionOfLineAndCharacter(lineStarts []core.TextPos, line int, char
 	return res
 }
 
-func GetLeadingCommentRanges(f ast.NodeFactoryCoercible, text string, pos int) iter.Seq[ast.CommentRange] {
+func GetLeadingCommentRanges(f *ast.NodeFactory, text string, pos int) iter.Seq[ast.CommentRange] {
 	return iterateCommentRanges(f, text, pos, false)
 }
 
-func GetTrailingCommentRanges(f ast.NodeFactoryCoercible, text string, pos int) iter.Seq[ast.CommentRange] {
+func GetTrailingCommentRanges(f *ast.NodeFactory, text string, pos int) iter.Seq[ast.CommentRange] {
 	return iterateCommentRanges(f, text, pos, true)
 }
 
@@ -2355,8 +2355,7 @@ Single-line comment ranges include the leading double-slash characters but not t
 line break. Multi-line comment ranges include the leading slash-asterisk and trailing
 asterisk-slash characters.
 */
-func iterateCommentRanges(fc ast.NodeFactoryCoercible, text string, pos int, trailing bool) iter.Seq[ast.CommentRange] {
-	f := fc.AsNodeFactory()
+func iterateCommentRanges(f *ast.NodeFactory, text string, pos int, trailing bool) iter.Seq[ast.CommentRange] {
 	return func(yield func(ast.CommentRange) bool) {
 		var pendingPos int
 		var pendingEnd int