Refactor onDidChangeConfiguration handler in favor of listener pattern (#212)

* Refactor onDidChangeConfiguration handler in favor of listener pattern

* Address comments in review

Author: Vigilans

src/settings.ts

@@ -16,23 +16,26 @@ export class Settings {
             if (!e.affectsConfiguration("java.dependency")) {
                 return;
             }
-            const updatedConfig = workspace.getConfiguration("java.dependency");
+            const oldConfig = this._dependencyConfig;
+            this._dependencyConfig = workspace.getConfiguration("java.dependency");
             for (const listener of this._configurationListeners) {
-                listener(updatedConfig, this._dependencyConfig);
+                listener(this._dependencyConfig, oldConfig);
             }
-            if (updatedConfig.showOutline !== this._dependencyConfig.showOutline
-                || updatedConfig.packagePresentation !== this._dependencyConfig.packagePresentation
-                || (updatedConfig.syncWithFolderExplorer !== this._dependencyConfig.syncWithFolderExplorer
+        }));
+        this.registerConfigurationListener((updatedConfig, oldConfig) => {
+            if (updatedConfig.showOutline !== oldConfig.showOutline
+                || updatedConfig.packagePresentation !== oldConfig.packagePresentation
+                || (updatedConfig.syncWithFolderExplorer !== oldConfig.syncWithFolderExplorer
                     && updatedConfig.syncWithFolderExplorer)) {
-                this._dependencyConfig = updatedConfig;
                 commands.executeCommand(Commands.VIEW_PACKAGE_REFRESH);
-            } else {
-                if (updatedConfig.autoRefresh !== this._dependencyConfig.autoRefresh) {
-                    SyncHandler.updateFileWatcher(updatedConfig.autoRefresh);
-                }
-                this._dependencyConfig = updatedConfig;
             }
-        }));
+        });
+        this.registerConfigurationListener((updatedConfig, oldConfig) => {
+            if (updatedConfig.autoRefresh !== oldConfig.autoRefresh) {
+                SyncHandler.updateFileWatcher(updatedConfig.autoRefresh);
+            }
+        });
+
         SyncHandler.updateFileWatcher(Settings.autoRefresh());
 
         context.subscriptions.push({ dispose: () => { this._configurationListeners = []; } });
@@ -100,4 +103,4 @@ enum PackagePresentation {
     Hierarchical = "hierarchical",
 }
 
-type Listener = (updatedConfig: WorkspaceConfiguration, dependencyConfig: WorkspaceConfiguration) => void;
+type Listener = (updatedConfig: WorkspaceConfiguration, oldConfig: WorkspaceConfiguration) => void;

src/views/dependencyDataProvider.ts

@@ -32,8 +32,8 @@ export class DependencyDataProvider implements TreeDataProvider<ExplorerNode> {
             instrumentOperation(Commands.VIEW_PACKAGE_OPEN_FILE, (_operationId, uri) => this.openFile(uri))));
         context.subscriptions.push(commands.registerCommand(Commands.VIEW_PACKAGE_OUTLINE,
             instrumentOperation(Commands.VIEW_PACKAGE_OUTLINE, (_operationId, uri, range) => this.goToOutline(uri, range))));
-        Settings.registerConfigurationListener((updatedConfig, dependencyConfig) => {
-            if (updatedConfig.refreshDelay !== dependencyConfig.refreshDelay) {
+        Settings.registerConfigurationListener((updatedConfig, oldConfig) => {
+            if (updatedConfig.refreshDelay !== oldConfig.refreshDelay) {
                 this.setRefreshDelay(updatedConfig.refreshDelay);
             }
         });