Skip to content

Add tests for hover contributions #53

New issue
New issue
Closed
#77
Closed
Add tests for hover contributions#53
#77
Assignees
aeschli
Labels
feature-requestRequest for new features or functionality
Milestone
 
November 2020
@alexkreidler

Description

@alexkreidler
alexkreidler
opened on Apr 11, 2020

The current tests use schema contributions to test various schema features.

However there are no tests for hover contributions, which poses a problem if one wanted to write alternative hover providers.

The relevant code is here:

vscode-json-languageservice/src/services/jsonHover.ts

Lines 54 to 60 in fabbc80

for (let i = this.contributions.length - 1; i >= 0; i--) {
const contribution = this.contributions[i];
const promise = contribution.getInfoContribution(document.uri, location);
if (promise) {
return promise.then(htmlContent => createHover(htmlContent));
}
}

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionality

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions