handle callback correctly for back button

Author: eleanorjboyd

src/features/creators/creationHelpers.ts

@@ -12,24 +12,24 @@ import { EnvironmentManagers, InternalEnvironmentManager } from '../../internal.
  */
 export async function promptForVenv(callback: () => void): Promise<boolean | undefined> {
     try {
+        const venvChoice = await showQuickPickWithButtons([{ label: 'Yes' }, { label: 'No' }], {
+            placeHolder: 'Would you like to create a new virtual environment for this project?',
+            ignoreFocusOut: true,
+            showBackButton: true,
+        });
+        if (!venvChoice) {
+            return undefined;
+        }
+        if (Array.isArray(venvChoice)) {
+            // Should not happen for single selection, but handle just in case
+            return venvChoice.some((item) => item.label === 'Yes');
+        }
+        return venvChoice.label === 'Yes';
     } catch (ex) {
         if (ex === QuickInputButtons.Back) {
             callback();
         }
     }
-    const venvChoice = await showQuickPickWithButtons([{ label: 'Yes' }, { label: 'No' }], {
-        placeHolder: 'Would you like to create a new virtual environment for this project?',
-        ignoreFocusOut: true,
-        showBackButton: true,
-    });
-    if (!venvChoice) {
-        return undefined;
-    }
-    if (Array.isArray(venvChoice)) {
-        // Should not happen for single selection, but handle just in case
-        return venvChoice.some((item) => item.label === 'Yes');
-    }
-    return venvChoice.label === 'Yes';
 }
 
 /**

src/features/creators/newPackageProject.ts

@@ -9,7 +9,6 @@ import {
     isCopilotInstalled,
     manageCopilotInstructionsFile,
     manageLaunchJsonFile,
-    promptForCopilotInstructions,
     promptForVenv,
     quickCreateNewVenv,
     replaceInFilesAndNames,
@@ -53,22 +52,14 @@ export class NewPackageProject implements PythonProjectCreator {
                 }
                 // Use helper to prompt for virtual environment creation
                 const callback = () => {
-                    if (options) {
-                        return this.create(options);
-                    } else {
-                        return this.create({ name: packageName } as PythonProjectCreatorOptions);
-                    }
+                    return this.create(options);
                 };
                 createVenv = await promptForVenv(callback);
                 if (createVenv === undefined) {
                     return undefined;
                 }
                 if (isCopilotInstalled()) {
-                    const copilotResult = await promptForCopilotInstructions();
-                    if (copilotResult === undefined) {
-                        return undefined;
-                    }
-                    createCopilotInstructions = copilotResult === true;
+                    createCopilotInstructions = true;
                 }
             }