Skip to content

Commit 2676c65

Browse files
committed
address comments
1 parent 10193bd commit 2676c65

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

src/cdk-experimental/testing/protractor/protractor-element.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,7 @@ export class ProtractorElement implements TestElement {
145145
async matchesSelector(selector: string): Promise<boolean> {
146146
return browser.executeScript(`
147147
return (Element.prototype.matches ||
148-
Element.prototype.matchesSelector ||
149-
Element.prototype.mozMatchesSelector ||
150-
Element.prototype.msMatchesSelector ||
151-
Element.prototype.oMatchesSelector ||
152-
Element.prototype.webkitMatchesSelector).call(arguments[0], arguments[1])
148+
Element.prototype.msMatchesSelector).call(arguments[0], arguments[1])
153149
`, this.element, selector);
154150
}
155151

src/cdk-experimental/testing/testbed/unit-test-element.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,8 @@ export class UnitTestElement implements TestElement {
141141
async matchesSelector(selector: string): Promise<boolean> {
142142
await this._stabilize();
143143
const elementPrototype = Element.prototype as any;
144-
return (elementPrototype['matches'] ||
145-
elementPrototype['matchesSelector'] ||
146-
elementPrototype['mozMatchesSelector'] ||
147-
elementPrototype['msMatchesSelector'] ||
148-
elementPrototype['oMatchesSelector'] ||
149-
elementPrototype['webkitMatchesSelector']).call(this.element, selector);
144+
return (elementPrototype['matches'] || elementPrototype['msMatchesSelector'])
145+
.call(this.element, selector);
150146
}
151147

152148
async forceStabilize(): Promise<void> {

src/material-experimental/mdc-menu/harness/mdc-menu-item-harness.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class MatMenuItemHarness extends ComponentHarness {
2626
* @return a `HarnessPredicate` configured with the given options.
2727
*/
2828
static with(options: MenuItemHarnessFilters = {}): HarnessPredicate<MatMenuItemHarness> {
29-
return new HarnessPredicate(MatMenuItemHarness, options); // TODO: add options here
29+
return new HarnessPredicate(MatMenuItemHarness, options);
3030
}
3131

3232
/** Gets a boolean promise indicating if the menu is disabled. */

0 commit comments

Comments
 (0)