remove unnecssary check in checkIn

baileympearson · baileympearson · commit a573e0ea238f · 2022-11-22T17:08:43.000-05:00
diff --git a/src/cmap/connection_pool.ts b/src/cmap/connection_pool.ts
@@ -399,10 +399,10 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
       this[kConnections].unshift(connection);
     }
 
-    const wasConnectionDeleted = this[kCheckedOut].delete(connection);
+    this[kCheckedOut].delete(connection);
     this.emit(ConnectionPool.CONNECTION_CHECKED_IN, new ConnectionCheckedInEvent(this, connection));
 
-    if (wasConnectionDeleted && willDestroy) {
+    if (willDestroy) {
       const reason = connection.closed ? 'error' : poolClosed ? 'poolClosed' : 'stale';
       this.destroyConnection(connection, reason);
     }

Original file line number	Diff line number	Diff line change
`@@ -399,10 +399,10 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {`
`399`	`399`	`this[kConnections].unshift(connection);`
`400`	`400`	`}`
`401`	`401`
`402`		`- const wasConnectionDeleted = this[kCheckedOut].delete(connection);`
	`402`	`+ this[kCheckedOut].delete(connection);`
`403`	`403`	`this.emit(ConnectionPool.CONNECTION_CHECKED_IN, new ConnectionCheckedInEvent(this, connection));`
`404`	`404`
`405`		`- if (wasConnectionDeleted && willDestroy) {`
	`405`	`+ if (willDestroy) {`
`406`	`406`	`const reason = connection.closed ? 'error' : poolClosed ? 'poolClosed' : 'stale';`
`407`	`407`	`this.destroyConnection(connection, reason);`
`408`	`408`	`}`