Merge pull request #161 from moremoban/windows-permission

Windows permission

Author: chfw

.moban.cd/changelog.yml

@@ -4,9 +4,10 @@ releases:
 - changes:
   - action: Updated
     details:
+    - "`#141`: disable file permissions copy feature and not to check file permission changes on windows."
     - "`#154`: introduce first ever positional argument for string base template."
     - "`#157`: the exit code behavior changed. for backward compactibility please use --exit-code. Otherwise, moban will not tell if there is any changes."
-  date: 11-1-2019
+  date: 12-1-2019
   version: 0.3.8
 - changes:
   - action: Updated

CHANGELOG.rst

@@ -1,12 +1,14 @@
 Change log
 ================================================================================
 
-0.3.8 - 11-1-2019
+0.3.8 - 12-1-2019
 --------------------------------------------------------------------------------
 
 Updated
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+#. `#141 <https://github.com/moremoban/moban/issues/141>`_: disable file
+   permissions copy feature and not to check file permission changes on windows.
 #. `#154 <https://github.com/moremoban/moban/issues/154>`_: introduce first ever
    positional argument for string base template.
 #. `#157 <https://github.com/moremoban/moban/issues/157>`_: the exit code

moban/utils.py

@@ -126,6 +126,8 @@ def file_permissions_copy(source, dest):
 
 
 def file_permissions(afile):
+    if sys.platform == "win32":
+        return "no-permission-support"
     if not os.path.exists(afile):
         raise exceptions.FileNotFound(afile)
     return stat.S_IMODE(os.stat(afile).st_mode)

tests/test_hash_store.py

@@ -1,7 +1,4 @@
 import os
-import sys
-
-from nose import SkipTest
 
 from moban.hashstore import HashStore
 
@@ -80,8 +77,6 @@ def test_dest_file_file_permision_changed(self):
         Save as above, but this time,
         the generated file had file permision change
         """
-        if sys.platform == "win32":
-            raise SkipTest("No actual chmod on windows")
         hs = HashStore()
         flag = hs.is_file_changed(*self.fixture)
         if flag:

tests/test_utils.py

@@ -44,6 +44,14 @@ def test_file_permission_copy():
     os.unlink(test_dest)
 
 
+def file_permissions_disabled_on_windows():
+    if sys.platform == 'win32':
+        permissions = file_permissions('abc')
+        eq_('no-permission-support', permissions)
+    else:
+        raise SkipTest("No test required")
+
+
 @raises(FileNotFound)
 def test_file_permissions_file_not_found():
     file_permissions("I does not exist")