Dogfood fix #93
Merged
Dogfood fix #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
dogfood-fix
branch
2 times, most recently
from
8c5d876 to
915df47
Compare
Re-instates check dropped in b8b61f8. Use --ignore-blank-lines because sphinx templates have trailing lines that are not wanted here, and 92b799a and others removed the custom handling of these, and moban doesnt yet have post-processors to handle this. git diff --ignore-blank-lines --exit-code still emits an exit code even if there was no applicable changes, even with git v2.22.0 on Travis' bionic image. Workaround with a shell loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly working around moremoban/moban#283