Skip to content

Commit 4fa9ce5

Browse files
author
dmitry
committed
Reverted Gopal's patch that allowed plugable interned string check
1. It introduced a significant slowdown 2. It didn't fix the real problem in APC (I'm goint to commit the fix) git-svn-id: http://svn.php.net/repository/php/php-src/trunk@313844 c90b9560-bf6c-de11-be94-00142212c4b1
1 parent 9a31f29 commit 4fa9ce5

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

Zend/zend_string.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,10 @@
3030
#endif
3131

3232
ZEND_API const char *(*zend_new_interned_string)(const char *str, int len, int free_src TSRMLS_DC);
33-
ZEND_API zend_bool (*zend_is_interned_string)(const char *str TSRMLS_DC);
3433
ZEND_API void (*zend_interned_strings_snapshot)(TSRMLS_D);
3534
ZEND_API void (*zend_interned_strings_restore)(TSRMLS_D);
3635

3736
static const char *zend_new_interned_string_int(const char *str, int len, int free_src TSRMLS_DC);
38-
static zend_bool zend_is_interned_string_int(const char *str TSRMLS_DC);
3937
static void zend_interned_strings_snapshot_int(TSRMLS_D);
4038
static void zend_interned_strings_restore_int(TSRMLS_D);
4139

@@ -66,7 +64,6 @@ void zend_interned_strings_init(TSRMLS_D)
6664
#endif
6765

6866
zend_new_interned_string = zend_new_interned_string_int;
69-
zend_is_interned_string = zend_is_interned_string_int;
7067
zend_interned_strings_snapshot = zend_interned_strings_snapshot_int;
7168
zend_interned_strings_restore = zend_interned_strings_restore_int;
7269
}
@@ -180,11 +177,6 @@ static const char *zend_new_interned_string_int(const char *arKey, int nKeyLengt
180177
#endif
181178
}
182179

183-
static zend_bool zend_is_interned_string_int(const char *s TSRMLS_DC)
184-
{
185-
return (((s) >= CG(interned_strings_start)) && ((s) < CG(interned_strings_end)));
186-
}
187-
188180
static void zend_interned_strings_snapshot_int(TSRMLS_D)
189181
{
190182
CG(interned_strings_snapshot_top) = CG(interned_strings_top);

Zend/zend_string.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include "zend.h"
2525

2626
ZEND_API extern const char *(*zend_new_interned_string)(const char *str, int len, int free_src TSRMLS_DC);
27-
ZEND_API extern zend_bool (*zend_is_interned_string)(const char *str TSRMLS_DC);
2827
ZEND_API extern void (*zend_interned_strings_snapshot)(TSRMLS_D);
2928
ZEND_API extern void (*zend_interned_strings_restore)(TSRMLS_D);
3029

@@ -34,7 +33,7 @@ void zend_interned_strings_dtor(TSRMLS_D);
3433
#ifndef ZTS
3534

3635
#define IS_INTERNED(s) \
37-
(zend_is_interned_string ? zend_is_interned_string((s) TSRMLS_CC) : 0)
36+
(((s) >= CG(interned_strings_start)) && ((s) < CG(interned_strings_end)))
3837

3938
#else
4039

0 commit comments

Comments
 (0)