Skip to content

Commit bc9f441

Browse files
nicochromeos-ci-prod
authored and
chromeos-ci-prod
committed
Delete a few unused constants
llvm/llvm-project#66576 makes std::string's ctor constexpr if it's short enough to fit in the short-string optimization. This allows the compiler to realize that these are unused. Deleting them is necessary to be able to update libc++. (Relying on std::string's ctor to be constexpr for storage isn't allowed per standard, see discussion on the pull request above.) Bug: none Change-Id: I860e1c67a7c15342901814dafbab262672c0d45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935335 Reviewed-by: Hans Wennborg <[email protected]> Auto-Submit: Nico Weber <[email protected]> Commit-Queue: Nico Weber <[email protected]> Owners-Override: Nico Weber <[email protected]> Cr-Commit-Position: refs/heads/main@{#1208958} CrOS-Libchrome-Original-Commit: 879cb86187c04e9e941c03174765e5030a5a9cba
1 parent 3cd7430 commit bc9f441

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

base/command_line_unittest.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,15 @@
3434

3535
namespace base {
3636

37+
#if BUILDFLAG(IS_WIN)
3738
// To test Windows quoting behavior, we use a string that has some backslashes
3839
// and quotes.
3940
// Consider the command-line argument: q\"bs1\bs2\\bs3q\\\"
4041
// Here it is with C-style escapes.
4142
static const CommandLine::StringType kTrickyQuoted =
4243
FILE_PATH_LITERAL("q\\\"bs1\\bs2\\\\bs3q\\\\\\\"");
44+
#endif
45+
4346
// It should be parsed by Windows as: q"bs1\bs2\\bs3q\"
4447
// Here that is with C-style escapes.
4548
static const CommandLine::StringType kTricky =

0 commit comments

Comments
 (0)