refactor: use dataclasses, no namedtuple

Author: nedbat

coverage/parser.py

@@ -13,6 +13,7 @@
 import token
 import tokenize
 
+from dataclasses import dataclass
 from types import CodeType
 from typing import (
     cast, Any, Callable, Dict, Iterable, List, Optional, Protocol, Sequence,
@@ -462,7 +463,8 @@ def _find_statements(self) -> Iterable[TLineNo]:
 # AST analysis
 #
 
-class ArcStart(collections.namedtuple("Arc", "lineno, cause")):
+@dataclass(frozen=True, order=True)
+class ArcStart:
     """The information needed to start an arc.
 
     `lineno` is the line number the arc starts from.
@@ -474,8 +476,8 @@ class ArcStart(collections.namedtuple("Arc", "lineno, cause")):
     to have `lineno` interpolated into it.
 
     """
-    def __new__(cls, lineno: TLineNo, cause: str | None = None) -> ArcStart:
-        return super().__new__(cls, lineno, cause)
+    lineno: TLineNo
+    cause: str = ""
 
 
 class TAddArcFn(Protocol):
@@ -1256,7 +1258,7 @@ def _combine_finally_starts(self, starts: set[ArcStart], exits: set[ArcStart]) -
         """
         causes = []
         for start in sorted(starts):
-            if start.cause is not None:
+            if start.cause:
                 causes.append(start.cause.format(lineno=start.lineno))
         cause = " or ".join(causes)
         exits = {ArcStart(xit.lineno, cause) for xit in exits}

coverage/sysmon.py

@@ -5,7 +5,6 @@
 
 from __future__ import annotations
 
-import dataclasses
 import functools
 import inspect
 import os
@@ -14,6 +13,7 @@
 import threading
 import traceback
 
+from dataclasses import dataclass
 from types import CodeType, FrameType
 from typing import (
     Any,
@@ -151,7 +151,7 @@ def _decorator(meth: AnyCallable) -> AnyCallable:
         return _decorator
 
 
-@dataclasses.dataclass
+@dataclass
 class CodeInfo:
     """The information we want about each code object."""
 

lab/benchmark/benchmark.py

@@ -2,7 +2,6 @@
 
 import collections
 import contextlib
-import dataclasses
 import itertools
 import os
 import random
@@ -13,6 +12,7 @@
 import time
 from pathlib import Path
 
+from dataclasses import dataclass
 from typing import Any, Dict, Iterable, Iterator, List, Optional, Tuple
 
 import tabulate
@@ -480,7 +480,7 @@ def __init__(self, path, slug):
         self.toxenv = None
 
 
-@dataclasses.dataclass
+@dataclass
 class Coverage:
     """A version of coverage.py to use, maybe None."""
 
@@ -537,7 +537,7 @@ def __init__(self, directory, slug="source", tweaks=None, env_vars=None):
         )
 
 
-@dataclasses.dataclass
+@dataclass
 class Env:
     """An environment to run a test suite in."""