Fixed all the things!!!! (by closing drivers)

Author: technige

test/v1/examples.test.js

@@ -36,6 +36,10 @@ describe('transaction', function() {
     session.run("MATCH (n) DETACH DELETE n").then(done);
   });
 
+  afterEach(function() {
+    driver.close();
+  });
+
   it('should document a minimum viable snippet', function(done) {
     // tag::minimum-snippet[]
     var driver = neo4j.driver("bolt://localhost");

test/v1/session.test.js

@@ -21,28 +21,39 @@ var neo4j = require("../../lib/v1");
 var StatementType = require("../../lib/v1/result-summary").statementType;
 
 describe('session', function() {
+
+  var driver, session;
+
+  beforeEach(function(done) {
+    driver = neo4j.driver("bolt://localhost");
+    session = driver.session();
+
+    session.run("MATCH (n) DETACH DELETE n").then(done);
+  });
+
+  afterEach(function() {
+    driver.close();
+  });
+
   it('should expose basic run/subscribe ', function(done) {
     // Given
-    var driver = neo4j.driver("bolt://localhost");
 
     // When & Then
     var records = [];
-    driver.session().run( "RETURN 1.0 AS a").subscribe( {
+    session.run( "RETURN 1.0 AS a").subscribe( {
       onNext : function( record ) {
         records.push( record );
       },
       onCompleted : function( ) {
         expect( records.length ).toBe( 1 );
         expect( records[0]['a'] ).toBe( 1 );
-        driver.close();
         done();
       }
     });
   });
 
   it('should keep context in subscribe methods ', function(done) {
     // Given
-    var driver = neo4j.driver("bolt://localhost");
     function myObserver(){
       this.local = 'hello';
       var privateLocal = 'hello';
@@ -53,55 +64,47 @@ describe('session', function() {
       this.onCompleted = function() {
         expect(privateLocal).toBe('hello');
         expect(this.local).toBe('hello');
-        driver.close();
         done();
       }
     }
 
     // When & Then
-    driver.session().run( "RETURN 1.0 AS a").subscribe(new myObserver());
+    session.run( "RETURN 1.0 AS a").subscribe(new myObserver());
   });
 
   it('should call observers onError on error ', function(done) {
-    // Given
-    var driver = neo4j.driver("bolt://localhost");
 
     // When & Then
     var records = [];
-    driver.session().run( "RETURN 1 AS").subscribe( {
+    session.run( "RETURN 1 AS").subscribe( {
       onError: function(error) {
         expect(error.fields.length).toBe(1);
-        driver.close();
         done();
       }
     });
   });
 
   it('should accept a statement object ', function(done) {
     // Given
-    var driver = neo4j.driver("bolt://localhost");
     var statement = {text: "RETURN 1 = {param} AS a", parameters: {param: 1}};
 
     // When & Then
     var records = [];
-    driver.session().run( statement ).subscribe( {
+    session.run( statement ).subscribe( {
       onNext : function( record ) {
         records.push( record );
       },
       onCompleted : function( ) {
         expect( records.length ).toBe( 1 );
         expect( records[0]['a'] ).toBe( true );
-        driver.close();
         done();
       }
     });
   });
 
   it('should expose basic run/then/then/then ', function(done) {
-    // Given
-    var driver = neo4j.driver("bolt://localhost");
     // When & Then
-    driver.session().run( "RETURN 1.0 AS a")
+    session.run( "RETURN 1.0 AS a")
     .then(
       function( records ) {
         expect( records.length ).toBe( 1 );
@@ -112,48 +115,42 @@ describe('session', function() {
         expect( records.length ).toBe( 1 );
         expect( records[0]['a'] ).toBe( 1 );
       }
-    ).then( function() { driver.close(); done(); })
+    ).then( function() { done(); })
   });
 
   it('should expose basic run/catch ', function(done) {
-    // Given
-    var driver = neo4j.driver("bolt://localhost");
     // When & Then
-    driver.session().run( "RETURN 1 AS").catch(
+    session.run( "RETURN 1 AS").catch(
       function(error) {
         expect( error.fields.length).toBe(1);
-        driver.close();
         done();
       }
     )
   });
 
   it('should expose summarize method for basic metadata ', function(done) {
     // Given
-    var driver = neo4j.driver("bolt://localhost");
     var statement = "CREATE (n:Label {prop:{prop}}) RETURN n";
     var params = {prop: "string"}
     // When & Then
-    driver.session().run( statement, params )
+    session.run( statement, params )
           .then(function(result) {
       var sum = result.summary;
       expect(sum.statement.text).toBe( statement );
       expect(sum.statement.parameters).toBe( params );
       expect(sum.updateStatistics.containsUpdates()).toBe(true);
       expect(sum.updateStatistics.nodesCreated()).toBe(1);
       expect(sum.statementType).toBe(StatementType.READ_WRITE);
-      driver.close();
       done();
     });
   });
 
   it('should expose plan ', function(done) {
     // Given
-    var driver = neo4j.driver("bolt://localhost");
     var statement = "EXPLAIN CREATE (n:Label {prop:{prop}}) RETURN n";
     var params = {prop: "string"}
     // When & Then
-    driver.session()
+    session
           .run( statement, params )
           .then(function(result) {
       var sum = result.summary;
@@ -163,18 +160,16 @@ describe('session', function() {
       expect(sum.plan.arguments.runtime).toBe('INTERPRETED');
       expect(sum.plan.identifiers[0]).toBe('n');
       expect(sum.plan.children[0].operatorType).toBe('CreateNode');
-      driver.close();
       done();
     });
   });
 
   it('should expose profile ', function(done) {
     // Given
-    var driver = neo4j.driver("bolt://localhost");
     var statement = "PROFILE MATCH (n:Label {prop:{prop}}) RETURN n";
     var params = {prop: "string"}
     // When & Then
-    driver.session()
+    session
           .run( statement, params )
           .then(function(result) {
       var sum = result.summary;
@@ -184,34 +179,29 @@ describe('session', function() {
       expect(sum.profile.arguments.runtime).toBe('INTERPRETED');
       expect(sum.profile.identifiers[0]).toBe('n');
       expect(sum.profile.children[0].operatorType).toBe('Filter');
-      expect(sum.profile.rows).toBeGreaterThan(0);
+      expect(sum.profile.rows).toBe(0);
       //expect(sum.profile.dbHits).toBeGreaterThan(0);
-      driver.close();
       done();
     });
   });
 
   it('should expose cypher notifications ', function(done) {
     // Given
-    var driver = neo4j.driver("bolt://localhost");
     var statement = "EXPLAIN MATCH (n), (m) RETURN n, m";
     // When & Then
-    driver.session()
+    session
           .run( statement )
           .then(function(result) {
       var sum = result.summary;
       expect(sum.notifications.length).toBeGreaterThan(0);
       expect(sum.notifications[0].code).toBe("Neo.ClientNotification.Statement.CartesianProduct");
       expect(sum.notifications[0].title).toBe("This query builds a cartesian product between disconnected patterns.");
       expect(sum.notifications[0].position.column).toBeGreaterThan(0);
-      driver.close();
       done();
     });
   });
 
   it('should fail when using the session when having an open transaction', function (done) {
-    // Given
-    var session = neo4j.driver("bolt://localhost").session();
 
     // When
     session.beginTransaction();
@@ -220,14 +210,12 @@ describe('session', function() {
     session.run("RETURN 42")
       .catch(function (error) {
         expect(error.error).toBe("Please close the currently open transaction object before running " +
-          "more statements/transactions in the current session." )
+          "more statements/transactions in the current session." );
         done();
       })
   });
 
   it('should fail when opening multiple transactions', function () {
-    // Given
-    var session = neo4j.driver("bolt://localhost").session();
 
     // When
     session.beginTransaction();

test/v1/transaction.test.js

@@ -30,7 +30,11 @@ describe('transaction', function() {
     session.run("MATCH (n) DETACH DELETE n").then(done);
   });
 
- it('should handle simple transaction', function(done) {
+  afterEach(function() {
+    driver.close();
+  });
+
+  it('should handle simple transaction', function(done) {
     // When
     var tx = session.beginTransaction();
     tx.run("CREATE (:TXNode1)");