Skip to content

fix: specify node version >=14.15 <18 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 12, 2022
Merged

fix: specify node version >=14.15 <18 #439

merged 10 commits into from
Jul 12, 2022

Conversation

kevinsamoei
Copy link
Contributor

@kevinsamoei kevinsamoei commented Jul 11, 2022 •
edited
Loading

  • Lighthouse v9 does not work with node v18
  • This updates the node version in package.json to match anything between v14.15 and 18
  • Updated tests to run on v17.9

@kevinsamoei kevinsamoei requested a review from a team July 11, 2022 19:26
@kevinsamoei kevinsamoei marked this pull request as draft July 11, 2022 19:30
@kevinsamoei kevinsamoei removed the request for review from a team July 11, 2022 19:30
@kevinsamoei kevinsamoei marked this pull request as ready for review July 11, 2022 20:10
@kevinsamoei kevinsamoei changed the title fix: Update node version fix: specify node version >=14.15 <18 Jul 11, 2022
nasivuela
nasivuela reviewed Jul 12, 2022
View reviewed changes
netlify.toml Outdated
@@ -3,7 +3,7 @@ command = "echo 'no op'"
publish = "example"

[build.environment]
NODE_VERSION = "16.15.1"
NODE_VERSION = "17.9.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stay on LTS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have an LTS on v17.* so I set it to 16.15.1 which is an LTS

nasivuela
nasivuela approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@nasivuela nasivuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinsamoei kevinsamoei merged commit 30cb14d into main Jul 12, 2022
@kevinsamoei kevinsamoei deleted the update-node-version branch July 12, 2022 13:25
@token-generator-app token-generator-app bot mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasivuela nasivuela nasivuela approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinsamoei @nasivuela