You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem:
c52b4da added comments to variables in Makefile, which
broke Makefile logic because the variable values got trailing space
character.
Solution:
- Remove the trailing space character for variables with comments
- Update help-generation Makefile code to account that
Tests:
Manual. make, make build, make container, make create-kind-cluster
ran successfully.
PREFIX ?= nginx-kubernetes-gateway## The name of the image. For example, nginx-kubernetes-gateway
8
-
TAG ?= $(VERSION:v%=%)## The tag of the image. For example, 0.3.0
9
-
TARGET ?= local## The target of the build. Possible values: local and container
10
-
KIND_KUBE_CONFIG_FOLDER = $${HOME}/.kube/kind## The folder where the kind kubeconfig is stored
11
-
OUT_DIR ?= $(shell pwd)/build/out## The folder where the binary will be stored
12
-
ARCH ?= amd64## The architecture of the image and/or binary. For example: amd64 or arm64
13
-
override DOCKER_BUILD_OPTIONS += --build-arg VERSION=$(VERSION) --build-arg GIT_COMMIT=$(GIT_COMMIT) --build-arg DATE=$(DATE)## The options for the docker build command. For example, --pull
7
+
PREFIX ?= nginx-kubernetes-gateway## The name of the image. For example, nginx-kubernetes-gateway
8
+
TAG ?= $(VERSION:v%=%)## The tag of the image. For example, 0.3.0
9
+
TARGET ?= local## The target of the build. Possible values: local and container
10
+
KIND_KUBE_CONFIG_FOLDER = $${HOME}/.kube/kind## The folder where the kind kubeconfig is stored
11
+
OUT_DIR ?= $(shell pwd)/build/out## The folder where the binary will be stored
12
+
ARCH ?= amd64## The architecture of the image and/or binary. For example: amd64 or arm64
13
+
override DOCKER_BUILD_OPTIONS += --build-arg VERSION=$(VERSION) --build-arg GIT_COMMIT=$(GIT_COMMIT) --build-arg DATE=$(DATE)## The options for the docker build command. For example, --pull
0 commit comments