Add default path with matches are nil

Author: ciarams87

internal/mode/static/state/graph/graph_test.go

@@ -399,7 +399,7 @@ func TestBuildGraph(t *testing.T) {
 		Spec: L7RouteSpec{
 			Hostnames: gr.Spec.Hostnames,
 			Rules: []RouteRule{
-				createValidRuleWithBackendRefs([]gatewayv1.HTTPRouteMatch{}),
+				createValidRuleWithBackendRefs(routeMatches),
 			},
 		},
 	}

internal/mode/static/state/graph/grpcroute.go

@@ -132,6 +132,20 @@ func processGRPCRouteRules(
 }
 
 func convertGRPCMatches(grpcMatches []v1alpha2.GRPCRouteMatch) []v1.HTTPRouteMatch {
+	pathValue := "/"
+	pathType := v1.PathMatchType("PathPrefix")
+	// If no matches are specified, the implementation MUST match every gRPC request.
+	if len(grpcMatches) == 0 {
+		return []v1.HTTPRouteMatch{
+			{
+				Path: &v1.HTTPPathMatch{
+					Type:  &pathType,
+					Value: helpers.GetPointer(pathValue),
+				},
+			},
+		}
+	}
+
 	hms := make([]v1.HTTPRouteMatch, 0, len(grpcMatches))
 
 	for _, gm := range grpcMatches {
@@ -145,8 +159,6 @@ func convertGRPCMatches(grpcMatches []v1alpha2.GRPCRouteMatch) []v1.HTTPRouteMat
 		}
 		hm.Headers = hmHeaders
 
-		pathValue := "/"
-		pathType := v1.PathMatchType("PathPrefix")
 		if gm.Method != nil && gm.Method.Service != nil && gm.Method.Method != nil {
 			// if method match is provided, service and method are required
 			// as the only method type supported is exact.

internal/mode/static/state/graph/grpcroute_test.go

@@ -154,6 +154,26 @@ func TestBuildGRPCRoute(t *testing.T) {
 		[]v1alpha2.GRPCRouteRule{methodMatchRule, headersMatchRule},
 	)
 
+	backendRef := v1.BackendRef{
+		BackendObjectReference: v1.BackendObjectReference{
+			Kind:      helpers.GetPointer[v1.Kind]("Service"),
+			Name:      "service1",
+			Namespace: helpers.GetPointer[v1.Namespace]("test"),
+			Port:      helpers.GetPointer[v1.PortNumber](80),
+		},
+	}
+
+	grpcBackendRef := v1alpha2.GRPCBackendRef{
+		BackendRef: backendRef,
+	}
+
+	grEmptyMatch := createGRPCRoute(
+		"gr-1",
+		gatewayNsName.Name,
+		"example.com",
+		[]v1alpha2.GRPCRouteRule{{BackendRefs: []v1alpha2.GRPCBackendRef{grpcBackendRef}}},
+	)
+
 	grInvalidHostname := createGRPCRoute("gr-1", gatewayNsName.Name, "", []v1alpha2.GRPCRouteRule{methodMatchRule})
 	grNotNGF := createGRPCRoute("gr", "some-gateway", "example.com", []v1alpha2.GRPCRouteRule{methodMatchRule})
 
@@ -261,6 +281,35 @@ func TestBuildGRPCRoute(t *testing.T) {
 			},
 			name: "normal case with both",
 		},
+		{
+			validator: createAllValidValidator(),
+			gr:        grEmptyMatch,
+			expected: &L7Route{
+				RouteType: RouteTypeGRPC,
+				Source:    grEmptyMatch,
+				ParentRefs: []ParentRef{
+					{
+						Idx:         0,
+						Gateway:     gatewayNsName,
+						SectionName: grEmptyMatch.Spec.ParentRefs[0].SectionName,
+					},
+				},
+				Valid:      true,
+				Attachable: true,
+				Spec: L7RouteSpec{
+					Hostnames: grEmptyMatch.Spec.Hostnames,
+					Rules: []RouteRule{
+						{
+							ValidMatches:     true,
+							ValidFilters:     true,
+							Matches:          convertGRPCMatches(grEmptyMatch.Spec.Rules[0].Matches),
+							RouteBackendRefs: []RouteBackendRef{{BackendRef: backendRef}},
+						},
+					},
+				},
+			},
+			name: "valid rule with empty match",
+		},
 		{
 			validator: createAllValidValidator(),
 			gr:        grInvalidMatchesEmptyMethodFields,