Skip to content

Commit 286f3ea

Browse files
authored
Increase timeout for tracing test (#2068)
Problem: The tracing test can be flaky and traces occasionally don't show up in the collector in a timely manner. Solution: Remove the test retry, and replace with a longer timeout for sending requests and checking for traces. Unable to produce the issue locally, but seen in pipelines, so hoping that this helps.
1 parent 7b1eba0 commit 286f3ea

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

tests/suite/tracing_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,7 @@ import (
2323
"github.com/nginxinc/nginx-gateway-fabric/tests/framework"
2424
)
2525

26-
// This test can be flaky when waiting to see traces show up in the collector logs.
27-
// Sometimes they get there right away, sometimes it takes 30 seconds. Retries were
28-
// added to attempt to mitigate the issue, but it didn't fix it 100%
29-
var _ = Describe("Tracing", FlakeAttempts(2), Label("functional"), func() {
26+
var _ = Describe("Tracing", Label("functional", "tracing"), func() {
3027
var (
3128
files = []string{
3229
"hello-world/apps.yaml",
@@ -159,7 +156,7 @@ var _ = Describe("Tracing", FlakeAttempts(2), Label("functional"), func() {
159156
Should(Succeed())
160157

161158
// wait for expected first line to show up
162-
Eventually(findTraces, "1m", "5s").Should(BeTrue())
159+
Eventually(findTraces, "5m", "5s").Should(BeTrue())
163160
}
164161

165162
It("sends tracing spans for one policy attached to one route", func() {

0 commit comments

Comments
 (0)