Skip to content

Commit 3c90c22

Browse files
authored
Resolve AddToScheme FIXME (#236)
Panic if the Kubernetes API AddToScheme() calls fail on init.
1 parent dcd6a10 commit 3c90c22

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

internal/manager/manager.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
apiv1 "k8s.io/api/core/v1"
88
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
99
"k8s.io/apimachinery/pkg/runtime"
10+
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
1011
ctlr "sigs.k8s.io/controller-runtime"
1112
"sigs.k8s.io/controller-runtime/pkg/client"
1213
"sigs.k8s.io/controller-runtime/pkg/manager"
@@ -38,9 +39,8 @@ const (
3839
var scheme = runtime.NewScheme()
3940

4041
func init() {
41-
// FIXME(pleshakov): handle errors returned by the calls bellow
42-
_ = gatewayv1beta1.AddToScheme(scheme)
43-
_ = apiv1.AddToScheme(scheme)
42+
utilruntime.Must(gatewayv1beta1.AddToScheme(scheme))
43+
utilruntime.Must(apiv1.AddToScheme(scheme))
4444
}
4545

4646
func Start(cfg config.Config) error {

0 commit comments

Comments
 (0)