Skip to content

Commit 6682fce

Browse files
committed
Refactor upstream test name to include both OSS and Plus server count
1 parent 247bead commit 6682fce

File tree

1 file changed

+18
-31
lines changed

1 file changed

+18
-31
lines changed

tests/suite/scale_test.go

+18-31
Original file line numberDiff line numberDiff line change
@@ -571,37 +571,24 @@ The logs are attached only if there are errors.
571571
},
572572
)
573573
})
574-
if upstreamServerCount == ossUpstreamServerCount {
575-
It(fmt.Sprintf("scales upstream servers to %d", ossUpstreamServerCount), func() {
576-
const testName = "TestScale_UpstreamServers"
577-
578-
testResultsDir := filepath.Join(resultsDir, testName)
579-
Expect(os.MkdirAll(testResultsDir, 0o755)).To(Succeed())
580-
581-
runTestWithMetricsAndLogs(
582-
testName,
583-
testResultsDir,
584-
func() {
585-
runScaleUpstreams()
586-
},
587-
)
588-
})
589-
} else {
590-
It(fmt.Sprintf("scales upstream servers to %d", plusUpstreamServerCount), func() {
591-
const testName = "TestScale_UpstreamServers"
592-
593-
testResultsDir := filepath.Join(resultsDir, testName)
594-
Expect(os.MkdirAll(testResultsDir, 0o755)).To(Succeed())
595-
596-
runTestWithMetricsAndLogs(
597-
testName,
598-
testResultsDir,
599-
func() {
600-
runScaleUpstreams()
601-
},
602-
)
603-
})
604-
}
574+
575+
It(fmt.Sprintf("scales upstream servers to %d for OSS and %d for Plus",
576+
ossUpstreamServerCount,
577+
plusUpstreamServerCount,
578+
), func() {
579+
const testName = "TestScale_UpstreamServers"
580+
581+
testResultsDir := filepath.Join(resultsDir, testName)
582+
Expect(os.MkdirAll(testResultsDir, 0o755)).To(Succeed())
583+
584+
runTestWithMetricsAndLogs(
585+
testName,
586+
testResultsDir,
587+
func() {
588+
runScaleUpstreams()
589+
},
590+
)
591+
})
605592

606593
It("scales HTTP matches", func() {
607594
const testName = "TestScale_HTTPMatches"

0 commit comments

Comments
 (0)