Skip to content

Commit 92661af

Browse files
authored
Use yamllint action from reviewdog (#2186)
Problem: We manually install yamnllint without controlling the version Solution: Use an action-yamllint so we can pin the version and also get annotations
1 parent 04cfbc3 commit 92661af

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

.github/workflows/lint.yml

+11-12
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ permissions:
2121

2222
jobs:
2323
lint:
24-
name: Lint
24+
name: Go Lint
2525
runs-on: ubuntu-22.04
2626
strategy:
2727
fail-fast: false
@@ -36,10 +36,9 @@ jobs:
3636
with:
3737
go-version: stable
3838

39-
- name: Lint Code
39+
- name: Lint Go
4040
uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64 # v6.0.1
4141
with:
42-
args: --timeout 10m0s
4342
working-directory: ${{ matrix.directory }}
4443

4544
njs-lint:
@@ -82,7 +81,8 @@ jobs:
8281
- name: Checkout Repository
8382
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
8483

85-
- uses: reviewdog/action-actionlint@afad3b6ab835e5611bda8c8193377e2d5c21413d # v1.51.0
84+
- name: Lint Actions
85+
uses: reviewdog/action-actionlint@afad3b6ab835e5611bda8c8193377e2d5c21413d # v1.51.0
8686
with:
8787
actionlint_flags: -shellcheck ""
8888

@@ -93,10 +93,12 @@ jobs:
9393
- name: Checkout Repository
9494
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
9595

96-
- uses: DavidAnson/markdownlint-cli2-action@b4c9feab76d8025d1e83c653fa3990936df0e6c8 # v16.0.0
96+
- name: Lint Markdown
97+
uses: DavidAnson/markdownlint-cli2-action@b4c9feab76d8025d1e83c653fa3990936df0e6c8 # v16.0.0
9798
with:
98-
config: ${{ github.workspace }}/.markdownlint-cli2.yaml
99+
config: .markdownlint-cli2.yaml
99100
globs: "**/*.md"
101+
fix: false
100102

101103
chart-lint:
102104
name: Chart Lint
@@ -120,14 +122,11 @@ jobs:
120122
run: ct lint --print-config --config .ct.yaml
121123

122124
yaml-lint:
123-
name: Yaml Lint
125+
name: YAML lint
124126
runs-on: ubuntu-22.04
125127
steps:
126128
- name: Checkout Repository
127129
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
128130

129-
- name: Install yamllint
130-
run: pip install yamllint
131-
132-
- name: Lint YAML files
133-
run: yamllint .
131+
- name: Lint YAML
132+
uses: reviewdog/action-yamllint@508148c0d959b166798f9792d1b29dddcac37348 # v1.16.0

0 commit comments

Comments
 (0)