Enable yamllint for Helm Chart and GitHub Actions (#2018)

Problem: We're not linting YAML files in the Helm Chart and GitHub Actions directories

Solution: Enable yamllint for these directories and fix the problems.

Author: lucacome

.github/workflows/ci.yml

@@ -8,6 +8,8 @@ on:
     tags:
       - "v[0-9]+.[0-9]+.[0-9]+*"
   pull_request:
+    branches:
+      - "*"
   schedule:
     - cron: "0 4 * * *" # run every day at 4am UTC
 

.github/workflows/lint.yml

@@ -5,6 +5,8 @@ on:
     branches:
       - main
   pull_request:
+    branches:
+      - "*"
 
 defaults:
   run:

.github/workflows/nfr.yml

@@ -71,7 +71,7 @@ jobs:
 
     - name: Authenticate to Google Cloud
       id: auth
-      uses: google-github-actions/auth@71fee32a0bb7e97b4d33d548e7d957010649d8fa # v2.1.3
+      uses: google-github-actions/auth@71fee32a0bb7e97b4d33d548e7d957010649d8fa # v2.1.3
       with:
         token_format: access_token
         workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY }}
@@ -144,9 +144,9 @@ jobs:
       working-directory: ./tests
       run: |
         if ${{ inputs.test_label != 'all' }}; then
-          sed -i '/^GINKGO_LABEL=/s/=.*/="${{ inputs.test_label }}"/' "scripts/vars.env" && make nfr-test;
+        sed -i '/^GINKGO_LABEL=/s/=.*/="${{ inputs.test_label }}"/' "scripts/vars.env" && make nfr-test;
         else
-          make nfr-test;
+        make nfr-test;
         fi
 
     - name: Cleanup

.yamllint.yaml

@@ -4,10 +4,9 @@ yaml-files:
   - "*.yml"
 
 ignore:
-  - charts/nginx-gateway-fabric
+  - charts/nginx-gateway-fabric/templates
   - config/crd/bases/
   - deploy/crds.yaml
-  - .github/workflows/
 
 rules:
   braces: enable

charts/nginx-gateway-fabric/values.yaml

@@ -71,7 +71,8 @@ nginx:
   plus: false
 
   ## The configuration for the data plane that is contained in the NginxProxy resource.
-  config: {}
+  config:
+    {}
     # disableHTTP2: false
     # telemetry:
     #   exporter:
@@ -138,14 +139,14 @@ service:
   ## A list of ports to expose through the NGINX Gateway Fabric service. Update it to match the listener ports from
   ## your Gateway resource. Follows the conventional Kubernetes yaml syntax for service ports.
   ports:
-  - port: 80
-    targetPort: 80
-    protocol: TCP
-    name: http
-  - port: 443
-    targetPort: 443
-    protocol: TCP
-    name: https
+    - port: 80
+      targetPort: 80
+      protocol: TCP
+      name: http
+    - port: 443
+      targetPort: 443
+      protocol: TCP
+      name: https
 
 metrics:
   ## Enable exposing metrics in the Prometheus format.