Skip to content

Commit 6ab69ef

Browse files
author
Gabor Marton
committed
[analyzer][NFC] Rename GREngine->CoreEngine, GRExprEngine->ExprEngine in comments and txt files
fixes rust-lang#115
1 parent 7727d2a commit 6ab69ef

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

clang/lib/StaticAnalyzer/Core/ExprEngine.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//===----------------------------------------------------------------------===//
88
//
99
// This file defines a meta-engine for path-sensitive dataflow analysis that
10-
// is built on GREngine, but provides the boilerplate to execute transfer
10+
// is built on CoreEngine, but provides the boilerplate to execute transfer
1111
// functions and build the ExplodedGraph at the expression level.
1212
//
1313
//===----------------------------------------------------------------------===//

clang/lib/StaticAnalyzer/README.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
= Library Structure =
66

77
The analyzer library has two layers: a (low-level) static analysis
8-
engine (GRExprEngine.cpp and friends), and some static checkers
8+
engine (ExprEngine.cpp and friends), and some static checkers
99
(*Checker.cpp). The latter are built on top of the former via the
1010
Checker and CheckerVisitor interfaces (Checker.h and
1111
CheckerVisitor.h). The Checker interface is designed to be minimal
@@ -58,7 +58,7 @@ ImmutableMaps) which share data between instances.
5858

5959
Finally, individual Checkers work by also manipulating the analysis
6060
state. The analyzer engine talks to them via a visitor interface.
61-
For example, the PreVisitCallExpr() method is called by GRExprEngine
61+
For example, the PreVisitCallExpr() method is called by ExprEngine
6262
to tell the Checker that we are about to analyze a CallExpr, and the
6363
checker is asked to check for any preconditions that might not be
6464
satisfied. The checker can do nothing, or it can generate a new
@@ -92,7 +92,7 @@ method call.
9292
= Working on the Analyzer =
9393

9494
If you are interested in bringing up support for C++ expressions, the
95-
best place to look is the visitation logic in GRExprEngine, which
95+
best place to look is the visitation logic in ExprEngine, which
9696
handles the simulation of individual expressions. There are plenty of
9797
examples there of how other expressions are handled.
9898

clang/test/Analysis/PR3991.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ @implementation IHGoogleDocsAdapter - (id)initWithUsername:(NSString *)inUser
5050
// Actual test case:
5151
//
5252
// The analyzer currently doesn't reason about ObjCKVCRefExpr. Have both
53-
// GRExprEngine::Visit and GRExprEngine::VisitLValue have such expressions
53+
// ExprEngine::Visit and ExprEngine::VisitLValue have such expressions
5454
// evaluate to UnknownVal.
5555
//===----------------------------------------------------------------------===//
5656

clang/test/Analysis/misc-ps-eager-assume.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ void handle_assign_of_condition(int x) {
4949
// a symbolic value for this variable, but in the branch condition it is
5050
// promoted to 'int'. Currently the analyzer doesn't reason well about
5151
// promotions of symbolic values, so this test case tests the logic in
52-
// 'recoverCastedSymbol()' (GRExprEngine.cpp) to test that we recover
52+
// 'recoverCastedSymbol()' (ExprEngine.cpp) to test that we recover
5353
// path-sensitivity and use the symbol for 'needsAnArray' in the branch
5454
// condition.
5555
//
@@ -128,7 +128,7 @@ void rdar7342806(void) {
128128
// This test case depends on using -analyzer-config eagerly-assume=true and
129129
// -analyzer-store=region. The 'eagerly-assume=true' causes the path
130130
// to bifurcate when evaluating the function call argument, and a state
131-
// caching bug in GRExprEngine::CheckerVisit (and friends) caused the store
131+
// caching bug in ExprEngine::CheckerVisit (and friends) caused the store
132132
// to 'p' to not be evaluated along one path, but then an autotransition caused
133133
// the path to keep on propagating with 'p' still set to an undefined value.
134134
// We would then get a bogus report of returning uninitialized memory.

0 commit comments

Comments
 (0)