RF: Handle garbled versions in a way compatible with packaging.version

Author: effigies

nipype/interfaces/base/core.py

@@ -16,7 +16,7 @@
 import shutil
 import simplejson as json
 from traits.trait_errors import TraitError
-from packaging.version import Version
+from packaging.version import Version, InvalidVersion
 
 from ... import config, logging
 from ...utils.provenance import write_provenance
@@ -293,23 +293,26 @@ def _check_version_requirements(self, trait_object, permissive=False):
         check = dict(min_ver=lambda t: t is not None)
         names = trait_object.trait_names(**check)
 
+        if self.version:
+            try:
+                version = Version(str(self.version))
+            except InvalidVersion as err:
+                version = err
+
         if names and self.version:
-            version = Version(str(self.version))
             for name in names:
                 min_ver = Version(str(trait_object.traits()[name].min_ver))
-                try:
-                    too_old = min_ver > version
-                except TypeError as err:
+                if isinstance(version, InvalidVersion):
                     msg = (
-                        f"Nipype cannot validate the package version {version!r} for "
+                        f"Nipype cannot validate the package version {self.version} for "
                         f"{self.__class__.__name__}. Trait {name} requires version >={min_ver}."
                     )
                     if not permissive:
                         iflogger.warning(f"{msg}. Please verify validity.")
                     if config.getboolean("execution", "stop_on_unknown_version"):
-                        raise ValueError(msg) from err
+                        raise ValueError(msg) from version
                     continue
-                if too_old:
+                if min_ver > version:
                     unavailable_traits.append(name)
                     if not isdefined(getattr(trait_object, name)):
                         continue
@@ -323,22 +326,19 @@ def _check_version_requirements(self, trait_object, permissive=False):
         check = dict(max_ver=lambda t: t is not None)
         names = trait_object.trait_names(**check)
         if names and self.version:
-            version = Version(str(self.version))
             for name in names:
                 max_ver = Version(str(trait_object.traits()[name].max_ver))
-                try:
-                    too_new = max_ver < version
-                except TypeError as err:
+                if isinstance(version, InvalidVersion):
                     msg = (
-                        f"Nipype cannot validate the package version {version!r} for "
+                        f"Nipype cannot validate the package version {self.version} for "
                         f"{self.__class__.__name__}. Trait {name} requires version <={max_ver}."
                     )
                     if not permissive:
                         iflogger.warning(f"{msg}. Please verify validity.")
                     if config.getboolean("execution", "stop_on_unknown_version"):
-                        raise ValueError(msg) from err
+                        raise ValueError(msg) from version
                     continue
-                if too_new:
+                if max_ver < version:
                     unavailable_traits.append(name)
                     if not isdefined(getattr(trait_object, name)):
                         continue