ENH: Add segmentation output to FSL's epi_reg #2661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing fork up-to-date
Add segmentation output
Set default to false, in order to not overwrite the config file settings
The command EpiReg also produces a segmentation in white matter, gray matter, and csf which can now be accessed in nipype
|
Thanks for this. You'll need to check the acknowledgement that your changes will be released under Apache 2, and you may want to add yourself to the .zenodo.json file. |
effigies
changed the title
|
Could you also merge master, to fix the tests? |
Codecov Report
@@ Coverage Diff @@
## master #2661 +/- ##
==========================================
+ Coverage 67.59% 67.61% +0.02%
==========================================
Files 340 340
Lines 43054 43056 +2
Branches 5329 5329
==========================================
+ Hits 29104 29114 +10
+ Misses 13248 13241 -7
+ Partials 702 701 -1
Continue to review full report at Codecov.
|
effigies
reviewed
Jul 30, 2018
nipype/testing/data/reg_average_cmd
Outdated
| @@ -0,0 +1 @@ | |||
| reg_average /filesrv/weninger/code/nipype/nipype/testing/data/avg_out.nii.gz -avg im1.nii im2.nii im3.nii -omp 1 | |||
There was a problem hiding this comment.
This file probably shouldn't be here.
effigies
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes as proposed in: Issue #2657 Adding Segmentation Output to FSL:Epi_Reg
This output exists in fsl, but was not yet included in nipype
Closes #2657.
List of changes proposed in this PR (pull-request)
make check-before-commitAcknowledgment