Merge pull request #22 from nkaaf/fix_get_operation_on_immutable_tables_creating_a_new_object_instead_fo_referencing_it

Fix getting values of immutable lists containting pointers (like String)

Author: nkaaf

src/AbstractList.hpp

@@ -48,7 +48,7 @@ template <typename T> class AbstractList {
   /// Create a final Value from the given Value
 #define createFinalValue(value, finalValue, T)                                 \
   finalValue = (T *)malloc(sizeof(T));                                         \
-  memcpy(finalValue, &(value), sizeof(T));
+  memcpy(finalValue, &value, sizeof(T));
 
   /**
    * Class representing an abstract entry in the list.
@@ -65,6 +65,11 @@ template <typename T> class AbstractList {
      */
     explicit AbstractEntry(T *value) : value(value) {}
 
+    /*!
+     * @brief   Destructor of an AbstractEntry Object.
+     */
+    ~AbstractEntry() { value = nullptr; }
+
     /*!
      * @brief   Free the memory of the value to prevent memory leaks.
      */

src/DoubleLinkedList.hpp

@@ -51,6 +51,14 @@ template <typename T> class DoubleLinkedList : public AbstractList<T> {
      */
     explicit Entry(T *value) : AbstractList<T>::AbstractEntry(value) {}
 
+    /*!
+     * @brief   Destructor of an Entry Object.
+     */
+    ~Entry() {
+      next = nullptr;
+      prev = nullptr;
+    }
+
     /*!
      * @brief   Get the next entry of the list.
      *
@@ -109,9 +117,9 @@ template <typename T> class DoubleLinkedList : public AbstractList<T> {
     if (this->isMutable()) {
       return (T *)current->getValue();
     } else {
-      T val = *current->getValue();
+      T *val = current->getValue();
       T *finalValue;
-      createFinalValue(val, finalValue, T);
+      createFinalValue(*val, finalValue, T);
       return finalValue;
     }
   }

src/SingleLinkedList.hpp

@@ -50,6 +50,11 @@ template <typename T> class SingleLinkedList : public AbstractList<T> {
      */
     explicit Entry(T *value) : AbstractList<T>::AbstractEntry(value) {}
 
+    /*!
+     * @brief   Destructor of an Entry Object.
+     */
+    ~Entry() { next = nullptr; }
+
     /*!
      * @brief   Get the next entry of the list.
      *
@@ -87,9 +92,9 @@ template <typename T> class SingleLinkedList : public AbstractList<T> {
     if (this->isMutable()) {
       return (T *)current->getValue();
     } else {
-      T val = *current->getValue();
+      T *val = current->getValue();
       T *finalValue;
-      createFinalValue(val, finalValue, T);
+      createFinalValue(*val, finalValue, T);
       return finalValue;
     }
   }