return 0 (false) from Client.connect(hostname,port) when DNS-lookup didn't succeed

ntruchsess · ntruchsess · commit 6086a364f83b · 2014-01-15T13:24:27.000+01:00
diff --git a/UIPClient.cpp b/UIPClient.cpp
@@ -78,18 +78,16 @@ int
 UIPClient::connect(const char *host, uint16_t port)
 {
   // Look up the host first
-  int ret = 0;
 #if UIP_UDP
   DNSClient dns;
   IPAddress remote_addr;
 
   dns.begin(UIPEthernet.dnsServerIP());
-  ret = dns.getHostByName(host, remote_addr);
-  if (ret == 1) {
+  if (dns.getHostByName(host, remote_addr) == 1) {
     return connect(remote_addr, port);
   }
 #endif
-  return ret;
+  return 0;
 }
 
 void

Original file line number	Diff line number	Diff line change
`@@ -78,18 +78,16 @@ int`
`78`	`78`	`UIPClient::connect(const char *host, uint16_t port)`
`79`	`79`	`{`
`80`	`80`	`// Look up the host first`
`81`		`- int ret = 0;`
`82`	`81`	`#if UIP_UDP`
`83`	`82`	`DNSClient dns;`
`84`	`83`	`IPAddress remote_addr;`
`85`	`84`
`86`	`85`	`dns.begin(UIPEthernet.dnsServerIP());`
`87`		`- ret = dns.getHostByName(host, remote_addr);`
`88`		`- if (ret == 1) {`
	`86`	`+ if (dns.getHostByName(host, remote_addr) == 1) {`
`89`	`87`	`return connect(remote_addr, port);`
`90`	`88`	`}`
`91`	`89`	`#endif`
`92`		`- return ret;`
	`90`	`+ return 0;`
`93`	`91`	`}`
`94`	`92`
`95`	`93`	`void`