Skip to content

Commit 7f3daa8

Browse files
authored
Update GH actions to run successfully (#597)
* rector * formatting * bump symfony lts version * allow plugin
1 parent 70bd78c commit 7f3daa8

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

.github/workflows/frameworks.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ jobs:
1313
fail-fast: true
1414
matrix:
1515
os: [ubuntu-latest]
16-
version: ['^4.4', '@stable', '@dev'] # Test current LTS, current release, and future release
16+
version: ['^5.4', '@stable', '@dev'] # Test current LTS, current release, and future release
1717
php: ['7.4', '8.0', '8.1']
1818
composer-version: [v2]
1919
include:
20-
- version: '^4.4'
20+
- version: '^5.4'
2121
psr-simple-cache-version: '^1.0|^2.0'
2222
- version: '@stable'
2323
psr-simple-cache-version: '^1.0|^2.0|^3.0'
@@ -64,6 +64,10 @@ jobs:
6464
working-directory: ./project
6565
run: composer require "psr/simple-cache:${{ matrix.psr-simple-cache-version }}"
6666
continue-on-error: ${{ env.allow_failure == 'true' }}
67+
- name: Allow plugin
68+
working-directory: ./project
69+
run: composer config --no-plugins allow-plugins.dealerdirect/phpcodesniffer-composer-installer true
70+
continue-on-error: ${{ env.allow_failure == 'true' }}
6771
- name: Install PHPInsights
6872
working-directory: ./project
6973
run: composer require --dev "nunomaduro/phpinsights:*" -n --ansi --with-all-dependencies
@@ -133,6 +137,10 @@ jobs:
133137
working-directory: ./project
134138
run: composer require --dev phpunit/phpunit:^9.0 --update-with-dependencies -n --ansi
135139
continue-on-error: ${{ env.allow_failure == 'true' }}
140+
- name: Allow plugin
141+
working-directory: ./project
142+
run: composer config --no-plugins allow-plugins.dealerdirect/phpcodesniffer-composer-installer true
143+
continue-on-error: ${{ env.allow_failure == 'true' }}
136144
- name: Install PHPInsights
137145
working-directory: ./project
138146
run: composer require --dev "nunomaduro/phpinsights:*" -n --ansi --with-all-dependencies

src/Application/Adapters/WordPress/Preset.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,11 @@ public static function shouldBeApplied(Composer $composer): bool
5050
$requirements = $composer->getRequirements();
5151

5252
foreach (array_keys($requirements) as $requirement) {
53-
$requirement = (string) $requirement;
53+
if (strpos($requirement, 'johnpbloch/wordpress') !== false) {
54+
return true;
55+
}
5456

55-
if (strpos($requirement, 'johnpbloch/wordpress') !== false
56-
|| strpos($requirement, 'roots/wordpress') !== false) {
57+
if (strpos($requirement, 'roots/wordpress') !== false) {
5758
return true;
5859
}
5960
}

src/Domain/Insights/SyntaxCheck.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ private function getTarget(): string
113113
}
114114

115115
/**
116-
* Recursively search for composer binary folder path
116+
* Recursively search for composer binary folder path.
117117
*/
118118
private function composerBinaryFolderFind(string $directory): string
119119
{

0 commit comments

Comments
 (0)