Skip to content

Commit 95d2bb5

Browse files
committed
cleanups: PR link update + #5
1 parent 859acab commit 95d2bb5

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ yarn dev
8383

8484
### 3. [Reusable Styles](https://github.com/ohansemmanuel/advanced-react-patterns-ultrasimplified/pull/19)
8585

86-
### 4. [Control Props](https://github.com/ohansemmanuel/advanced-react-patterns-ultrasimplified/pull/6)
86+
### 4. [Control Props](https://github.com/ohansemmanuel/advanced-react-patterns-ultrasimplified/pull/21)
8787

8888
### 5. [Custom Hooks](https://github.com/ohansemmanuel/advanced-react-patterns-ultrasimplified/pull/7)
8989

showcase/src/Body.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const patterns = [
4747

4848
const PR_ROOT =
4949
'https://github.com/ohansemmanuel/advanced-react-patterns-ultrasimplified/pull'
50-
const PR_IDs = [1, 16, 17, 19, 6, 7, 8, 9, 10, 12]
50+
const PR_IDs = [1, 16, 17, 19, 21, 7, 8, 9, 10, 12]
5151
const PRs = PR_IDs.map(id => `${PR_ROOT}/${id}`)
5252

5353
const Header = ({ title, patternNumber }) => {

showcase/src/patterns/05.js

+4-7
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
import React, {
22
useState,
3-
useEffect,
43
useCallback,
4+
useEffect,
55
useLayoutEffect,
66
useContext,
7-
useMemo,
87
useRef,
8+
useMemo,
99
createContext
1010
} from 'react'
1111

1212
import mojs from 'mo-js'
1313
import { generateRandomNumber } from '../utils/generateRandomNumber'
1414
import styles from './index.css'
15-
import userStyles from './usage.css'
1615

1716
/** ====================================
1817
* 🔰Hook
@@ -99,7 +98,6 @@ const useClapAnimation = ({
9998
})
10099

101100
if (typeof burstEl === 'string') {
102-
const id = burstEl.slice(1, burstEl.length)
103101
const el = document.getElementById(id)
104102
el.style.transform = 'scale(1, 1)'
105103
} else {
@@ -143,7 +141,6 @@ const MediumClap = ({
143141
const { count, countTotal, isClicked } = clapState
144142

145143
const [{ clapRef, clapCountRef, clapTotalRef }, setRefState] = useState({})
146-
147144
const setRef = useCallback(node => {
148145
if (node !== null) {
149146
setRefState(prevRefState => ({
@@ -160,11 +157,11 @@ const MediumClap = ({
160157
burstEl: clapRef
161158
})
162159

163-
// Controlled Component ? isControlled = value !== undefined
160+
// Controlled Component??
161+
// isControlled = value !== undefined
164162
const isControlled = !!values
165163

166164
const handleClapClick = () => {
167-
// 👉 prop from HOC
168165
animationTimeline.replay()
169166
isControlled
170167
? onClap()

0 commit comments

Comments
 (0)