Skip to content

Commit 519a8de

Browse files
toddbaertaepfli
andauthored
chore: update min SDK version (#1152)
Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Simon Schrottner <[email protected]>
1 parent 8fb4194 commit 519a8de

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/MetricsHook.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ public void error(HookContext ctx, Exception error, Map hints) {
134134
}
135135

136136
@Override
137-
public void finallyAfter(HookContext ctx, Map hints) {
137+
public void finallyAfter(HookContext ctx, FlagEvaluationDetails details, Map hints) {
138138
activeFlagEvaluationsCounter.add(-1, Attributes.of(flagKeyAttributeKey, ctx.getFlagKey()));
139139
}
140140

hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/MetricsHookTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ public void finally_stage_validation() {
188188
final MetricsHook metricHook = new MetricsHook(telemetryExtension.getOpenTelemetry());
189189

190190
// when
191-
metricHook.finallyAfter(commonHookContext, null);
191+
metricHook.finallyAfter(commonHookContext, null, null);
192192
List<MetricData> metrics = telemetryExtension.getMetrics();
193193

194194
// then

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@
6767
<!-- this can be overriden in child POMs to support specific SDK requirements -->
6868
<groupId>dev.openfeature</groupId>
6969
<artifactId>sdk</artifactId>
70-
<!-- 1.12 <= v < 2.0 -->
71-
<version>[1.12,2.0)</version>
70+
<!-- 1.14 <= v < 2.0 (excluding 2.0 pre-releases)-->
71+
<version>[1.14,1.99999)</version>
7272
<!-- use the version provided at runtime -->
7373
<scope>provided</scope>
7474
</dependency>

0 commit comments

Comments
 (0)