chore: update failing tests

Signed-off-by: Todd Baert <[email protected]>

Author: toddbaert

providers/configcat/src/test/java/dev/openfeature/contrib/providers/configcat/ConfigCatProviderTest.java

@@ -218,6 +218,7 @@ void contextTransformTest() {
         String country = "someCountry";
         String customPropertyValue = "customProperty_value";
         String customPropertyKey = "customProperty";
+        String targetingKeyKey = "targetingKey";
 
         MutableContext evaluationContext = new MutableContext();
         evaluationContext.setTargetingKey(userId);
@@ -227,6 +228,7 @@ void contextTransformTest() {
 
         HashMap<String, Object > customMap = new HashMap<>();
         customMap.put(customPropertyKey, customPropertyValue);
+        customMap.put(targetingKeyKey, userId);
         User expectedUser = User.newBuilder().email(email).country(country).custom(customMap).build(userId);
         User transformedUser = ContextTransformer.transform(evaluationContext);
 

providers/statsig/src/test/java/dev/openfeature/contrib/providers/statsig/StatsigProviderTest.java

@@ -42,18 +42,19 @@
  */
 class StatsigProviderTest {
 
-    public static final String FLAG_NAME = "enabledFeature";
-    public static final String CONFIG_FLAG_NAME = "alias";
-    public static final String LAYER_FLAG_NAME = "alias";
-    public static final String CONFIG_FLAG_VALUE = "test";
-    public static final String INT_FLAG_NAME = "revision";
-    public static final String LAYER_INT_FLAG_NAME = "revision";
-    public static final Integer INT_FLAG_VALUE = 5;
-    public static final String DOUBLE_FLAG_NAME = "price";
-    public static final String LAYER_DOUBLE_FLAG_NAME = "price";
-    public static final Double DOUBLE_FLAG_VALUE = 3.14;
-    public static final String USERS_FLAG_NAME = "userIdMatching";
-    public static final String PROPERTIES_FLAG_NAME = "emailMatching";
+    private static final String FLAG_NAME = "enabledFeature";
+    private static final String CONFIG_FLAG_NAME = "alias";
+    private static final String LAYER_FLAG_NAME = "alias";
+    private static final String CONFIG_FLAG_VALUE = "test";
+    private static final String INT_FLAG_NAME = "revision";
+    private static final String LAYER_INT_FLAG_NAME = "revision";
+    private static final Integer INT_FLAG_VALUE = 5;
+    private static final String DOUBLE_FLAG_NAME = "price";
+    private static final String LAYER_DOUBLE_FLAG_NAME = "price";
+    private static final Double DOUBLE_FLAG_VALUE = 3.14;
+    private static final String USERS_FLAG_NAME = "userIdMatching";
+    private static final String PROPERTIES_FLAG_NAME = "emailMatching";
+    private static final String TARGETING_KEY = "a-targeting-key";
     private static StatsigProvider statsigProvider;
     private static Client client;
 
@@ -115,10 +116,10 @@ static void shutdown() {
 
     @Test
     void getBooleanEvaluation() {
-        assertEquals(true, statsigProvider.getBooleanEvaluation(FLAG_NAME, false, new ImmutableContext()).getValue());
-        assertEquals(true, client.getBooleanValue(FLAG_NAME, false));
-        assertEquals(false, statsigProvider.getBooleanEvaluation("non-existing", false, new ImmutableContext()).getValue());
-        assertEquals(false, client.getBooleanValue("non-existing", false));
+        assertEquals(true, statsigProvider.getBooleanEvaluation(FLAG_NAME, false, new ImmutableContext(TARGETING_KEY)).getValue());
+        assertEquals(true, client.getBooleanValue(FLAG_NAME, false, new ImmutableContext(TARGETING_KEY)));
+        assertEquals(false, statsigProvider.getBooleanEvaluation("non-existing", false, new ImmutableContext(TARGETING_KEY)).getValue());
+        assertEquals(false, client.getBooleanValue("non-existing", false, new ImmutableContext(TARGETING_KEY)));
 
         // expected to succeed when https://github.com/statsig-io/java-server-sdk/issues/22 is resolved and adopted
 //        assertEquals(true, client.getBooleanValue("non-existing", true));
@@ -128,6 +129,7 @@ void getBooleanEvaluation() {
         featureConfig.add("type", "CONFIG");
         featureConfig.add("name", "product");
         evaluationContext.add("feature_config", featureConfig);
+        evaluationContext.setTargetingKey(TARGETING_KEY);
         assertEquals(true, statsigProvider.getBooleanEvaluation("boolean", false,
             evaluationContext).getValue());
     }
@@ -139,6 +141,7 @@ void getStringEvaluation() {
         featureConfig.add("type", "CONFIG");
         featureConfig.add("name", "product");
         evaluationContext.add("feature_config", featureConfig);
+        evaluationContext.setTargetingKey(TARGETING_KEY);
         assertEquals(CONFIG_FLAG_VALUE, statsigProvider.getStringEvaluation(CONFIG_FLAG_NAME, "",
             evaluationContext).getValue());
         assertEquals(CONFIG_FLAG_VALUE, statsigProvider.getStringEvaluation(LAYER_FLAG_NAME, "",
@@ -153,6 +156,7 @@ void getObjectConfigEvaluation() {
         featureConfig.add("type", "CONFIG");
         featureConfig.add("name", "object-config-name");
         evaluationContext.add("feature_config", featureConfig);
+        evaluationContext.setTargetingKey(TARGETING_KEY);
         Value objectEvaluation = statsigProvider.getObjectEvaluation("dummy", new Value("fallback"),
             evaluationContext).getValue();
 
@@ -168,6 +172,7 @@ void getObjectLayerEvaluation() {
         featureConfig.add("type", "LAYER");
         featureConfig.add("name", "layer-name");
         evaluationContext.add("feature_config", featureConfig);
+        evaluationContext.setTargetingKey(TARGETING_KEY);
         Value objectEvaluation = statsigProvider.getObjectEvaluation("dummy", new Value("fallback"),
             evaluationContext).getValue();
 
@@ -184,6 +189,7 @@ void getIntegerEvaluation() {
         featureConfig.add("type", "CONFIG");
         featureConfig.add("name", "product");
         evaluationContext.add("feature_config", featureConfig);
+        evaluationContext.setTargetingKey(TARGETING_KEY);
         assertEquals(INT_FLAG_VALUE, statsigProvider.getIntegerEvaluation(INT_FLAG_NAME, 1,
             evaluationContext).getValue());
         assertEquals(INT_FLAG_VALUE, statsigProvider.getIntegerEvaluation(LAYER_INT_FLAG_NAME, 1,
@@ -201,6 +207,7 @@ void getDoubleEvaluation() {
         featureConfig.add("type", "CONFIG");
         featureConfig.add("name", "product");
         evaluationContext.add("feature_config", featureConfig);
+        evaluationContext.setTargetingKey(TARGETING_KEY);
         assertEquals(DOUBLE_FLAG_VALUE, statsigProvider.getDoubleEvaluation(DOUBLE_FLAG_NAME, 1.1,
             evaluationContext).getValue());
         assertEquals(DOUBLE_FLAG_VALUE, statsigProvider.getDoubleEvaluation(LAYER_DOUBLE_FLAG_NAME, 1.1,
@@ -314,6 +321,7 @@ void contextTransformTest() {
         String locale = "locale1";
         String customPropertyValue = "customProperty_value";
         String customPropertyKey = "customProperty";
+        String targetingKeyKey = "targetingKey";
 
         MutableContext evaluationContext = new MutableContext();
         evaluationContext.setTargetingKey(userId);
@@ -331,6 +339,7 @@ void contextTransformTest() {
 
         HashMap<String, String > customMap = new HashMap<>();
         customMap.put(customPropertyKey, customPropertyValue);
+        customMap.put(targetingKeyKey, userId);
         StatsigUser expectedUser = new StatsigUser(evaluationContext.getTargetingKey());
         expectedUser.setEmail(email);
         expectedUser.setCountry(country);