feat(flagd-inprocess): Use program flow instead of exceptions for flag not found errors

Exceptions are expensive GOTO statements, and in a performance
relevant system not the best to be used for control flow
. A FlagNotFound-Error can be expected, but the performance
draw backs of exception in this case not.

Signed-off-by: Simon Schrottner <[email protected]>

Author: aepfli

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java

@@ -12,6 +12,7 @@
 import dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.grpc.GrpcStreamConnector;
 import dev.openfeature.contrib.providers.flagd.resolver.process.targeting.Operator;
 import dev.openfeature.contrib.providers.flagd.resolver.process.targeting.TargetingRuleException;
+import dev.openfeature.sdk.ErrorCode;
 import dev.openfeature.sdk.EvaluationContext;
 import dev.openfeature.sdk.ImmutableMetadata;
 import dev.openfeature.sdk.ProviderEvaluation;
@@ -166,12 +167,18 @@ private <T> ProviderEvaluation<T> resolve(Class<T> type, String key,
 
         // missing flag
         if (flag == null) {
-            throw new FlagNotFoundError("flag: " + key + " not found");
+           return ProviderEvaluation.<T>builder()
+                   .errorMessage("flag: " + key + " not found")
+                   .errorCode(ErrorCode.FLAG_NOT_FOUND)
+                   .build();
         }
 
         // state check
         if ("DISABLED".equals(flag.getState())) {
-            throw new FlagNotFoundError("flag: " + key + " is disabled");
+            return ProviderEvaluation.<T>builder()
+                    .errorMessage("flag: " + key + " is disabled")
+                    .errorCode(ErrorCode.FLAG_NOT_FOUND)
+                    .build();
         }
 
         final String resolvedVariant;

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolverTest.java

@@ -7,6 +7,7 @@
 import dev.openfeature.contrib.providers.flagd.resolver.process.storage.StorageState;
 import dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.file.FileConnector;
 import dev.openfeature.contrib.providers.flagd.resolver.process.storage.connector.grpc.GrpcStreamConnector;
+import dev.openfeature.sdk.ErrorCode;
 import dev.openfeature.sdk.ImmutableContext;
 import dev.openfeature.sdk.ImmutableMetadata;
 import dev.openfeature.sdk.MutableContext;
@@ -231,10 +232,8 @@ public void missingFlag() throws Exception {
         });
 
         // when/then
-        assertThrows(FlagNotFoundError.class, () -> {
-            inProcessResolver.booleanEvaluation("missingFlag", false, new ImmutableContext());
-
-        });
+        ProviderEvaluation<Boolean> missingFlag = inProcessResolver.booleanEvaluation("missingFlag", false, new ImmutableContext());
+        assertEquals(ErrorCode.FLAG_NOT_FOUND, missingFlag.getErrorCode());
     }
 
     @Test
@@ -247,9 +246,8 @@ public void disabledFlag() throws Exception {
         });
 
         // when/then
-        assertThrows(FlagNotFoundError.class, () -> {
-            inProcessResolver.booleanEvaluation("disabledFlag", false, new ImmutableContext());
-        });
+        ProviderEvaluation<Boolean> disabledFlag = inProcessResolver.booleanEvaluation("disabledFlag", false, new ImmutableContext());
+        assertEquals(ErrorCode.FLAG_NOT_FOUND, disabledFlag.getErrorCode());
     }
 
     @Test

tools/junit-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/OpenFeature.java

@@ -24,7 +24,7 @@
     /**
      * Collection of {@link Flag} configurations for this domain.
      */
-    Flag[] value();
+    Flags value();
 }