Skip to content

Commit eec04d1

Browse files
committed
fixup: add flag change assertion
Signed-off-by: Todd Baert <[email protected]>
1 parent 3008deb commit eec04d1

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/process/FlagdInProcessSetup.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import dev.openfeature.sdk.FeatureProvider;
1313
import io.cucumber.java.BeforeAll;
1414
import org.testcontainers.containers.GenericContainer;
15-
import org.testcontainers.utility.DockerImageName;
1615

1716
@Isolated()
1817
@Order(value = Integer.MAX_VALUE)

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/StepDefinitions.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public class StepDefinitions {
6565
private FlagEvaluationDetails<Integer> typeErrorDetails;
6666

6767
private boolean isChangeHandlerRun = false;
68+
private String changedFlag;
6869
private boolean isReadyHandlerRun = false;
6970

7071
private Consumer<EventDetails> changeHandler;
@@ -419,6 +420,7 @@ public void the_returned_value_should_be(Integer expectedValue) {
419420
public void a_provider_configuration_changed_handler_is_added() {
420421
this.changeHandler = (EventDetails details) -> {
421422
this.isChangeHandlerRun = true;
423+
this.changedFlag = details.getFlagsChanged().get(0);
422424
};
423425
client.onProviderConfigurationChanged(this.changeHandler);
424426

@@ -440,7 +442,7 @@ public void the_provider_configuration_changed_handler_must_run() {
440442

441443
@Then("the event details must indicate {string} was altered")
442444
public void the_event_details_must_indicate_was_altered(String flagKey) {
443-
// TODO: In-process-provider doesnt support flag change list.
445+
assertEquals(flagKey, this.changedFlag);
444446
}
445447

446448
// Provider ready event

0 commit comments

Comments
 (0)