Skip to content

fix: make flagd config EvaluatorType public #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

detached
Copy link
Contributor

@detached detached commented Oct 9, 2024

Make flagd config EvaluatorType public

This PR makes the EvaluatorType interface public, so that the implementing enums can then be used in Kotlin.

Related Issues

Fixes #1013

Notes

This bug in Kotlin prevents the usage of that enums in a Kotlin project: https://youtrack.jetbrains.com/issue/KT-11700

How to test

Code like the following should not lead to a runtime error:

    fun getFlagdProvider(): FlagdProvider = FlagdProvider(
        FlagdOptions.builder()
            .resolverType(Config.Resolver.IN_PROCESS)
            .build()
    )

@detached detached requested a review from a team as a code owner October 9, 2024 13:15
@detached detached changed the title Make EvaluatorType public Make flagd config EvaluatorType public Oct 9, 2024
@detached detached changed the title Make flagd config EvaluatorType public fix: make flagd config EvaluatorType public Oct 9, 2024
@toddbaert
Copy link
Member

toddbaert commented Oct 9, 2024

@detached Hey, happy to accept this, but the CNCF policy requires all commits to be signed off. Please do a git commit --amend --signoff and force push your changes back up. (see the failed DCO check): https://github.com/open-feature/java-sdk-contrib/pull/1014/checks?check_run_id=31296104106

@detached detached force-pushed the issue-1013-make-interface-public branch from 0ea0ce5 to 5f09685 Compare October 10, 2024 06:06
@detached
Copy link
Contributor Author

Thank you for approving!
I have pushed the commit signed.

The implementing enums can then be used in Kotlin.

Signed-off-by: Simon Weis <[email protected]>
@detached detached force-pushed the issue-1013-make-interface-public branch from 5f09685 to 2cb1a6b Compare October 10, 2024 14:41
@toddbaert toddbaert merged commit c99c66b into open-feature:main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flagd-provider] package-private interface prevents resolverType option usage with Kotlin
6 participants